Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent minikube profile command to create profile #6647

Closed
medyagh opened this issue Feb 15, 2020 · 4 comments · Fixed by #6672
Closed

Prevent minikube profile command to create profile #6647

medyagh opened this issue Feb 15, 2020 · 4 comments · Fixed by #6672
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Feb 15, 2020

one un-intentional side effect of minikube profile command is creating a new profile.

minikube profiles should only be created by minikube start.

so if you by mistake do

minikube profile lis

(instead of list)

it will create an abandoned profile called list.
I would like to disable the creation of profile by minikube profile command.

however, 'minikube profile pname'
should still change the profile to 'pname' if it exists. but should not create a new one.

and it shoud also send a nice message to the user if it doesnt exist.

"The profie lis doesnt exist, if you want to create a profile you can by this command
minikube start -p lis
"

@medyagh medyagh added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 15, 2020
@vikkyomkar
Copy link
Contributor

@medyagh I will take-up this issue and create a PR

@medyagh
Copy link
Member Author

medyagh commented Feb 17, 2020

@vikkyomkar it is yours ! please let me know what time you think you could make this. to see if we should include it in this milestone.

@aallbrig
Copy link
Contributor

aallbrig commented Feb 17, 2020

@medyagh I see there is no open PR for this issue. I'm going to try my hand at a solution.

@aallbrig
Copy link
Contributor

however, 'minikube profile pname'
should still change the profile to 'pname' if it exists. but should not create a new one.

@medyagh I think I have a solution but I am having problems confirming behavior you reported as being expected. I don't think minikube profile pname changes profile to pname.

I'm going to open a PR soon but I wanted to know more about this behavior you had described.

Screenshot 2020-02-17 18 53 24

Screenshot 2020-02-17 18 53 33

Screenshot 2020-02-17 18 53 43

Screenshot 2020-02-17 18 53 54

Screenshot 2020-02-17 18 54 01

Screenshot 2020-02-17 19 04 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants