Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-env cant detect shell in github actions ubuntu VM #6643

Closed
medyagh opened this issue Feb 15, 2020 · 1 comment · Fixed by #6661
Closed

docker-env cant detect shell in github actions ubuntu VM #6643

medyagh opened this issue Feb 15, 2020 · 1 comment · Fixed by #6661
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.

Comments

@medyagh
Copy link
Member

medyagh commented Feb 15, 2020

on integration tests in github actions minikube docker-env can not detect the shell
link to full logs https://github.com/kubernetes/minikube/suites/459846392/artifacts/1883061

=== RUN   TestFunctional/parallel/DockerEnv
=== PAUSE TestFunctional/parallel/DockerEnv
=== CONT  TestFunctional/parallel/DockerEnv
--- FAIL: TestFunctional/parallel/DockerEnv (0.37s)
functional_test.go:125: (dbg) Run:  /bin/bash -c "eval $(./minikube-linux-amd64 -p functional-20200215T014938.120977049-2685 docker-env) && ./minikube-linux-amd64 status -p functional-20200215T014938.120977049-2685"
functional_test.go:125: (dbg) Non-zero exit: /bin/bash -c "eval $(./minikube-linux-amd64 -p functional-20200215T014938.120977049-2685 docker-env) && ./minikube-linux-amd64 status -p functional-20200215T014938.120977049-2685": exit status 1 (372.293742ms)
** stderr ** 
* 
X Error detecting shell: Error: Unknown shell
* 
* minikube is exiting due to an error. If the above message is not useful, open an issue:
- https://github.com/kubernetes/minikube/issues/new/choose
/bin/bash: eval: line 0: unexpected EOF while looking for matching `''
/bin/bash: eval: line 1: syntax error: unexpected end of file
** /stderr **
functional_test.go:127: Failed to do minikube status after eval-ing docker-env exit status 1

The workflow Yaml file section:

    - name: Run integration test
      continue-on-error: true
      # bash {0} to allow test to continue to next step. in case of
      shell: bash {0}
      run: |
        cd minikube_binaries
        mkdir -p report
        mkdir -p testhome
        chmod a+x e2e-*
        chmod a+x minikube-*
        START_TIME=$(date -u +%s)
        KUBECONFIG=$(pwd)/testhome/kubeconfig MINIKUBE_HOME=$(pwd)/testhome ./e2e-linux-amd64 -minikube-start-args=--vm-driver=docker -expected-default-driver= -test.timeout=70m -test.v -binary=./minikube-linux-amd64 2>&1 | tee ./report/testout.txt
        END_TIME=$(date -u +%s)
        TIME_ELAPSED=$(($END_TIME-$START_TIME)) 
        min=$((${TIME_ELAPSED}/60))
        sec=$((${TIME_ELAPSED}%60))
        TIME_ELAPSED="${min} min $sec seconds "
        echo ::set-env name=TIME_ELAPSED::${TIME_ELAPSED}

@medyagh medyagh changed the title docker-env cant detect shell in github actions docker-env cant detect shell in github actions ubuntu VM Feb 15, 2020
@medyagh medyagh added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Feb 15, 2020
@afbjorklund
Copy link
Collaborator

@medyagh : we are using libmachine for this, and it just looks at $SHELL

https://github.com/docker/machine/blob/master/libmachine/shell/shell.go

So you probably want to set SHELL=/bin/bash in the environment ?

Since you have already selected bash, as the runner shell: bash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants