-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
offline support broken: LoadImages makes HTTPS queries #6103
Comments
See kubeadm related issue: 524. |
Update: For minikube side, I have seen that we will do retrieveImage while load images to container runtime, and for no networking access environment, it would broken. Maybe we could add a config option for this, to skip the Thanks. |
Thank you for bringing this to our attention. I can confirm that offline support is broken in minikube v1.6.1: My bet is that this was an unexpected side effect of #5987 Here's the error that made me suspicious:
Here's another example from running locally without Docker installed:
We'll make sure to fix this ASAP. /cc @medyagh |
@Colstuwjx Thank you so much for taking the time to create this bug ! this is definitely a bug ! I regret that it was a side effect of my improving cache PR. I am sorry for the inconvenience it caused to offline users andI really appreciate it that you reported it. and thanks for @tstromberg for creating a quick fix PR with integration tests so this may never happen again ! |
The exact command to reproduce the issue:
minikube start
It seems that docker daemon inside minikube vm would pull docker images even we have been cached all things, included iso,images etc.
According to the disk cache reference said,
maybe we need to also make docker daemon do NOT pull the cached images?
Thanks.
The full output of the command that failed:
The output of the
minikube logs
command:The operating system version: MacOS mojave
The text was updated successfully, but these errors were encountered: