Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube config emits no such file config.json when setting container-runtime #5961

Closed
danmack opened this issue Nov 22, 2019 · 4 comments
Closed
Labels
co/runtime/containerd co/runtime/crio CRIO related issues kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@danmack
Copy link

danmack commented Nov 22, 2019

The exact command to reproduce the issue:

Below, setting configuration options for my minikube environment. Minikube is not running when performing these commands.

(tensor) ~ > minikube config set cpus 6
⚠️ These changes will take effect upon a minikube delete and then a minikube start
(tensor) ~ > minikube config set memory 8192
⚠️ These changes will take effect upon a minikube delete and then a minikube start
(tensor) ~ > minikube config set container-runtime crio

💣 Set failed: [config.Load: stat /Users/mack/.minikube/profiles/minikube/config.json: no such file or directory]

😿 Sorry that minikube crashed. If this was unexpected, we would love to hear from you:
👉 https://github.com/kubernetes/minikube/issues/new/choose

The full output of the command that failed:

💣 Set failed: [config.Load: stat /Users/mack/.minikube/profiles/minikube/config.json: no such file or directory]

😿 Sorry that minikube crashed. If this was unexpected, we would love to hear from you:
👉 https://github.com/kubernetes/minikube/issues/new/choose

The output of the minikube logs command:

(tensor) ~ > minikube logs

💣 Error getting config: stat /Users/mack/.minikube/profiles/minikube/config.json: no such file or directory

😿 Sorry that minikube crashed. If this was unexpected, we would love to hear from you:
👉 https://github.com/kubernetes/minikube/issues/new/choose

The operating system version:

macOS 10.15.1 (Catalina)

@afbjorklund
Copy link
Collaborator

afbjorklund commented Nov 23, 2019

This is a bug in the IsContainerdRuntime function, which tries to do config.Load

Which seems to be invalid, as that function is only supposed to be used with gvisor.

Introduced in 043c45d (for #4788)

@RA489 ?

@afbjorklund afbjorklund added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. co/runtime/crio CRIO related issues co/runtime/containerd labels Nov 23, 2019
@afbjorklund
Copy link
Collaborator

Have no idea why this "crashes" on (allegedly) invalid configuration.

It would be enough with the "💣 Set failed:", once validation is correct.

@danmack
Copy link
Author

danmack commented Nov 23, 2019

Wow thanks for quick turnaround - one question - does the fix deal with the fact that apparently you can pass in both "crio" and "cri-o" as values for the runtime ?

@afbjorklund
Copy link
Collaborator

It should allow for both, just didn't add multiple test cases.

@afbjorklund afbjorklund added this to the v1.6.0 milestone Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/runtime/containerd co/runtime/crio CRIO related issues kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

2 participants