Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet command-line arguments redundant with newly enabled config file #5719

Closed
thomas-riccardi opened this issue Oct 24, 2019 · 2 comments
Closed

Comments

@thomas-riccardi
Copy link

With #5697 (fixing #5329) the kubelet command-line arguments are/would be redundant (or may be different than) the newly used /var/lib/kubelet/config.yaml.

It's probably better to have the values only once: either cmdline or config file.

I'm not even sure if all the values are the same:

  • the cmdline is built in /pkg/minikube/bootstrapper/kubeadm/versions.go
  • the kubelet config file is defined in /pkg/minikube/bootstrapper/kubeadm/templates.go, generated in /pkg/minikube/bootstrapper/kubeadm/kubeadm.go as a kubeadmCfg, but it's not really kubeadmin config (it's kubelet config), isn't it? (and there is a kubeletCfg next to it, but it contains other things... I'm lost :) )
@thomas-riccardi thomas-riccardi changed the title kubelet commandl-ine arguments redundant with newly enabled config file kubelet command-line arguments redundant with newly enabled config file Oct 24, 2019
@medyagh
Copy link
Member

medyagh commented Nov 4, 2019

closing this issue.
I believe this issue has be resolved by the PR. please feel free to reopen

@medyagh medyagh closed this as completed Nov 4, 2019
@thomas-riccardi
Copy link
Author

@medyagh it's not really resolved, it was deemed acceptable for now, with guidance to clean this later (here: #5697 (comment)).

I think this issue here could be used to track the mentioned cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants