You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With #5697 (fixing #5329) the kubelet command-line arguments are/would be redundant (or may be different than) the newly used /var/lib/kubelet/config.yaml.
It's probably better to have the values only once: either cmdline or config file.
I'm not even sure if all the values are the same:
the cmdline is built in /pkg/minikube/bootstrapper/kubeadm/versions.go
the kubelet config file is defined in /pkg/minikube/bootstrapper/kubeadm/templates.go, generated in /pkg/minikube/bootstrapper/kubeadm/kubeadm.go as a kubeadmCfg, but it's not really kubeadmin config (it's kubelet config), isn't it? (and there is a kubeletCfg next to it, but it contains other things... I'm lost :) )
The text was updated successfully, but these errors were encountered:
thomas-riccardi
changed the title
kubelet commandl-ine arguments redundant with newly enabled config file
kubelet command-line arguments redundant with newly enabled config file
Oct 24, 2019
With #5697 (fixing #5329) the
kubelet
command-line arguments are/would be redundant (or may be different than) the newly used/var/lib/kubelet/config.yaml
.It's probably better to have the values only once: either cmdline or config file.
I'm not even sure if all the values are the same:
/pkg/minikube/bootstrapper/kubeadm/versions.go
/pkg/minikube/bootstrapper/kubeadm/templates.go
, generated in/pkg/minikube/bootstrapper/kubeadm/kubeadm.go
as akubeadmCfg
, but it's not really kubeadmin config (it's kubelet config), isn't it? (and there is akubeletCfg
next to it, but it contains other things... I'm lost :) )The text was updated successfully, but these errors were encountered: