Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete should be able to delete the .minikube folder (w/ a flag) #5358

Closed
blueelvis opened this issue Sep 15, 2019 · 4 comments · Fixed by #5548
Closed

delete should be able to delete the .minikube folder (w/ a flag) #5358

blueelvis opened this issue Sep 15, 2019 · 4 comments · Fixed by #5548
Assignees
@blueelvis
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@blueelvis
Copy link
Contributor

From #4980 (comment)

minikube delete should have a switch/flag to delete the .minikube folder as well. This should ask for confirmation and display a warning before proceeding ahead.

/assign
@tstromberg
Copy link
Contributor

tstromberg commented Sep 16, 2019 •
edited
Loading

I personally don't agree with this issue, but it's worth discussing. My main issue with it is:

  • minikube delete is for deleting single clusters.
  • ~/.minikube is shared configuration and data files

Apps typically don't delete their configuration files except as part of uninstallation, and even then, very rarely so.

@tstromberg tstromberg added the triage/discuss Items for discussion label Sep 16, 2019
@blueelvis
Copy link
Contributor Author

Agreed. Let's discuss. This could be added to the installation/uninstallation steps for sure.

Regarding the delete, I believe that we should have the flag. Nothing that the user will be defaulted to.

@SlurmMcKenzie
Copy link

In Apt Package Management (Debian) you have an extra option for deleting configuration: --purge. Would that fit?

@tstromberg
Copy link
Contributor

tstromberg commented Sep 19, 2019 •
edited
Loading

@SlurmMcKenzie - Yes, that seems like a better behavior. I'd be happy to see a similar kind of flag to minikube delete.

@tstromberg tstromberg added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 19, 2019
@tstromberg tstromberg changed the title Minikube Delete should be able to delete the .minikube folder as well delete should be able to delete the .minikube folder w/ a flag Sep 19, 2019
@tstromberg tstromberg changed the title delete should be able to delete the .minikube folder w/ a flag delete should be able to delete the .minikube folder (w/ a flag) Sep 19, 2019
@tstromberg tstromberg added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Sep 19, 2019
@tstromberg tstromberg removed the triage/discuss Items for discussion label Sep 30, 2019
This was referenced Oct 2, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blueelvis blueelvis

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added flags to purge configuration with minikube delete blueelvis/minikube
3 participants
@tstromberg @blueelvis @SlurmMcKenzie