Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube service could handle multiple-ports-per-service better #5200

Closed
mathuin opened this issue Aug 26, 2019 · 4 comments · Fixed by #5290
Closed

minikube service could handle multiple-ports-per-service better #5200

mathuin opened this issue Aug 26, 2019 · 4 comments · Fixed by #5290
Labels
co/service issues related to the service feature help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@mathuin
Copy link

mathuin commented Aug 26, 2019

The exact command to reproduce the issue:

  1. Create a service with two ports in the spec, perhaps for Minecraft.
  2. Run minikube service nothing-minecraft.

The full output of the command that failed:


Strictly speaking, the command does not fail. It's just not very helpful.

|-----------|-------------------|--------------------------------|
| NAMESPACE |       NAME        |              URL               |
|-----------|-------------------|--------------------------------|
| default   | nothing-minecraft | http://192.168.99.100:32225    |
|           |                   | http://192.168.99.100:32412    |
|-----------|-------------------|--------------------------------|

This could be improved by adding a column for the service port name:

|-----------|-------------------|--------|--------------------------------|
| NAMESPACE |       NAME        |  PORT  |              URL               |
|-----------|-------------------|--------|--------------------------------|
| default   | nothing-minecraft | server | http://192.168.99.100:32225    |
|           |                   | dynmap | http://192.168.99.100:32412    |
|-----------|-------------------|--------|--------------------------------|

I'm not sure if this column should always be there or only when there is more than one service. I have no preference, myself.

It would also be nice to specify the port on the command line for those wishing to open a URL in their default browser -- wouldn't do much good to open the Minecraft server port, for instance, but browsing the dynmap service would be helpful.

The output of the minikube logs command:


Not relevant

The operating system version:
Not relevant

@medyagh
Copy link
Member

medyagh commented Aug 27, 2019

I was thinking maybe we could have an option to forward all the ports of the service in the cluster
maybe minikube service --all ?

https://github.com/txn2/kubefwd

@tstromberg ?

@tstromberg
Copy link
Contributor

Sounds reasonable to me.

@tstromberg tstromberg added co/service issues related to the service feature help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Aug 30, 2019
@11janci
Copy link
Contributor

11janci commented Sep 6, 2019

Hi, I'd like to work on this

@11janci
Copy link
Contributor

11janci commented Sep 7, 2019

Pls see the above PR, I currently show the new column always as I personally think it is not worth it adding a flag just for this and don't see any harm having it. Pls let me know if you'd like to change that behaviour (might be worth hiding it when empty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/service issues related to the service feature help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants