Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wait for start time duration configurable #5122

Closed
medyagh opened this issue Aug 18, 2019 · 0 comments · Fixed by #5121
Closed

Make wait for start time duration configurable #5122

medyagh opened this issue Aug 18, 2019 · 0 comments · Fixed by #5121
Assignees
Labels
kind/flake Categorizes issue or PR as related to a flaky test.

Comments

@medyagh
Copy link
Member

medyagh commented Aug 18, 2019

in integration tests (mostly virtualbox since it is heavier than other vms) in which some times we run 6+ VMs in parallel and it is reasonable to accept a longer wait time.

we need to make "ReasonableStartTime" variable which is currently constant, configurable, to avoid doing Retry in integration tests for start.

we also need to make sure we wait for each component correctly for example for some components it needs milliseconds to wait for and some more than 56 seconds!

example log: https://storage.googleapis.com/minikube-builds/logs/5095/VirtualBox_macOS.txt

 21:18:42 | ! X Wait failed: waiting for component=etcd: timed out waiting for the condition
 21:18:42 | ! * 
 21:18:42 | ! * Sorry that minikube crashed. If this was unexpected, we would love to hear from you:

WaitForPodsWithLabelRunning on Hyperkit (mac os)

Name Time
k8s-app=kube-proxy 9.022185663s NOT SO BAD
component=etcd 56.515008972s BAD
component=kube-scheduler 4.369296ms GOOD :)
component=kube-controller-manager 3.431618ms GOOD :)
k8s-app=kube-dns 5.533562ms GOOD:)

WaitForPodsWithLabelRunning on Virtualbox (mac os)

Name Time
k8s-app=kube-proxy 9.51573752s NOT SO BAD
component=etcd 1m18.511212486s BAD
component=kube-scheduler 11.708301ms GOOD :)
component=kube-controller-manager 43.938549ms GOOD :)
k8s-app=kube-dns 7.746797ms GOOD :)

waitForAPIServer

32.352155ms to wait for apiserver status ...

@medyagh medyagh added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 18, 2019
@medyagh medyagh changed the title Make ReasonableStartTime configurable Make wait for start time duration configurable Aug 18, 2019
@medyagh medyagh added the kind/flake Categorizes issue or PR as related to a flaky test. label Aug 18, 2019
@medyagh medyagh self-assigned this Aug 18, 2019
@medyagh medyagh removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/flake Categorizes issue or PR as related to a flaky test.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant