Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notification has wrong URL #5101

Closed
shouptech opened this issue Aug 16, 2019 · 2 comments · Fixed by #5109
Closed

Update notification has wrong URL #5101

shouptech opened this issue Aug 16, 2019 · 2 comments · Fixed by #5109
Assignees
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@shouptech
Copy link

The upgrade notification displays a URL like this:
https://github.com/kubernetes/minikube/releases/tag/v/1.3.1
The correct URL should be:
https://github.com/kubernetes/minikube/releases/tag/v1.3.1

There's an extra slash between v and 1.3

The exact command to reproduce the issue:
This happens when my shell (zsh) loads the tab completion.

The full output of the command that failed:


minikube 1.3.1 is available! Download it: https://github.com/kubernetes/minikube/releases/tag/v/1.3.1

The output of the minikube logs command:


N/A

The operating system version:
Linux <> 5.0.0-21-generic #22+system76-Ubuntu SMP Tue Jul 16 19:57:52 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

@tstromberg tstromberg self-assigned this Aug 16, 2019
@tstromberg
Copy link
Contributor

Hum. How on earth did that happen?

Spoiler alert: I broke it in a refactor:
3d7c657

@tstromberg tstromberg added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 16, 2019
@tstromberg
Copy link
Contributor

Thank you for opening an issue rather than just letting this bug sit and aggravate future users =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants