Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependecy on k8s.io/kubernetes in go mod #4656

Closed
medyagh opened this issue Jul 1, 2019 · 4 comments
Closed

Remove dependecy on k8s.io/kubernetes in go mod #4656

medyagh opened this issue Jul 1, 2019 · 4 comments
Assignees
@josedonizetti
Labels
area/dependency Issues or PRs related to dependency changes good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Jul 1, 2019 •
edited
Loading

While I was trying to bump up the dependecy in go mod for k8s.io/kubernetes 1.11.3
I noticed we our go mod fails because we are importing the whole kubernetes. and I could not add a new depedency on kubectl subpackage.

Thanks to the help on golang issues, (golang/go#32864) I found out the root cause is Kubernetes is is not meant to be imported as a go module See comment golang/go#32776 (comment) . we need to import only sub-packages kuberentes and delete k8s.io/kubernetes in the the go.mod

it is a good opportunity to upgrade to 1.15.0 ( there is a few breaking api changes for apimachinary that watch.Until needs to be changed to use api machinary wait package.

if I have time I will do this, but if someone wants to take this, I would be happy to review the PR.
@medyagh medyagh added area/dependency Issues or PRs related to dependency changes help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jul 1, 2019
@josedonizetti
Copy link
Member

I'll take this.

@medyagh
Copy link
Member Author

medyagh commented Jul 1, 2019 •
edited
Loading

Thank you @josedonizetti for taking this , I came across this comment kubernetes/kubernetes#79384 (comment) recomending using replace () it might be helpful to you . let me know if you have any questions

@dfang
Copy link
Contributor

dfang commented Jul 2, 2019

@medyagh currently replace() in go.mod is hard to upgrade the version of the replacement.

see golang/go#32721

@josedonizetti josedonizetti mentioned this issue Jul 9, 2019
Merged
@tstromberg tstromberg added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 16, 2019
@medyagh
Copy link
Member Author

medyagh commented Aug 1, 2019

closed by #4719 thank you @josedonizetti

@medyagh medyagh closed this as completed Aug 1, 2019
@tnqn tnqn mentioned this issue Jun 17, 2020
Merged
@mqasimsarfraz mqasimsarfraz mentioned this issue May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josedonizetti josedonizetti

Labels
area/dependency Issues or PRs related to dependency changes good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@josedonizetti @tstromberg @dfang @medyagh