Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ingress-nginx to latest release #4578

Closed
dimara opened this issue Jun 24, 2019 · 1 comment
Closed

Update ingress-nginx to latest release #4578

dimara opened this issue Jun 24, 2019 · 1 comment
Labels
addon/ingress good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@dimara
Copy link
Contributor

dimara commented Jun 24, 2019

Minikube currently uses ingress-nginx 0.23.0. In this release the x-forwarded-prefix annotation is broken (see kubernetes/ingress-nginx#3733). This should be fixed with 0.24.0 (see kubernetes/ingress-nginx#3786).

The above fix is not backwards compatible and requires modifying the annotation, i.e., pass the actual prefix instead of a boolean "true", but I guess this is better than not working at all, right?

Is there any reason not to update ingress-nginx to the latest release, i.e., 0.24.1?
@medyagh medyagh added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jun 24, 2019
@medyagh
Copy link
Member

medyagh commented Jun 24, 2019

I don't see any reason not to upgrade. I would be happy to review any PR that fixes this.

@medyagh medyagh added priority/backlog Higher priority than priority/awaiting-more-evidence. addon/ingress kind/bug Categorizes issue or PR as related to a bug. labels Jun 24, 2019
@fenglixa fenglixa mentioned this issue Jun 25, 2019
Merged
@medyagh medyagh closed this as completed Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addon/ingress good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dimara @medyagh