Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing Test Windows: File Path #4433

Closed
medyagh opened this issue Jun 5, 2019 · 0 comments · Fixed by #4434
Closed

Failing Test Windows: File Path #4433

medyagh opened this issue Jun 5, 2019 · 0 comments · Fixed by #4434
Assignees
@medyagh
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.

Comments

@medyagh
Copy link
Member

medyagh commented Jun 5, 2019 •
edited
Loading

The current integration tests on windows fail, because of the file path that is using the unix way.

for example:

	podPath, _ := filepath.Abs("testdata/busybox-mount-test.yaml")

https://github.com/kubernetes/minikube/blob/master/test/integration/tunnel_test.go#L65

throws the error :

"C:\\var\\jenkins\\workspace\\Windows_Integration_Tests_hyperV\\testdata\\busybox-mount-test.yaml": pods "busybox-mount" not found
@medyagh medyagh added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Jun 5, 2019
@medyagh medyagh mentioned this issue Jun 6, 2019
Merged
@medyagh medyagh self-assigned this Jun 6, 2019
@medyagh medyagh removed good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@medyagh medyagh

Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing file path for windows medyagh/minikube
1 participant
@medyagh