Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestNewSSHClient flake: Error running "foo": wait: remote command exited #4346

Closed
tstromberg opened this issue May 24, 2019 · 1 comment · Fixed by #4823
Closed

TestNewSSHClient flake: Error running "foo": wait: remote command exited #4346

tstromberg opened this issue May 24, 2019 · 1 comment · Fixed by #4823
Assignees
Labels
area/testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/flake Categorizes issue or PR as related to a flaky test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@tstromberg
Copy link
Contributor

As seen at https://travis-ci.org/kubernetes/minikube/builds/536576254?utm_source=github_status&utm_medium=notification and on other builds:

ok  	k8s.io/minikube/pkg/minikube/service	0.028s	coverage: 40.7% of statements
--- FAIL: TestNewSSHClient (0.19s)
    sshutil_test.go:53: Error running command: foo
FAIL
coverage: 75.0% of statements
FAIL	k8s.io/minikube/pkg/minikube/sshutil	0.197s
ok  	k8s.io/minikube/pkg/minikube/tunnel	2.073s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	0.847s	coverage: 51.7% of statements
make: *** [test] Error 16
The command "make test" exited with 2.

Based on the timing, this may be related by recent updates to sshutil and supporting libraries that fixed lint errors.

@tstromberg tstromberg added area/testing priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 24, 2019
@tstromberg tstromberg added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 12, 2019
@tstromberg
Copy link
Contributor Author

Although we now have better logs, this is still an issue:

--- FAIL: TestNewSSHClient (0.61s)
    ssh_mock.go:173: Listening on 127.0.0.1:37039
    ssh_mock.go:83: Accepting...
    ssh_mock.go:83: Accepting...
    ssh_mock.go:132: exec request received: &{Type:exec WantReply:true Payload:[0 0 0 3 102 111 111] ch:0xc00010c0c0 mux:<nil>}
    sshutil_test.go:60: Error running "foo": wait: remote command exited without exit status or exit signal
    ssh_mock.go:189: Stopping

@tstromberg tstromberg reopened this Sep 16, 2019
@tstromberg tstromberg added this to the v1.5.0-candidate milestone Sep 16, 2019
@tstromberg tstromberg changed the title TestNewSSHClient is flaky: sshutil_test.go:53: Error running command: foo TestNewSSHClient is flaky: Error running "foo": wait: remote command exited Sep 16, 2019
@tstromberg tstromberg changed the title TestNewSSHClient is flaky: Error running "foo": wait: remote command exited TestNewSSHClient flake: Error running "foo": wait: remote command exited Sep 16, 2019
@tstromberg tstromberg added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/flake Categorizes issue or PR as related to a flaky test. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Sep 18, 2019
@tstromberg tstromberg modified the milestones: v1.5.0, v1.6.0-candidate Oct 14, 2019
@tstromberg tstromberg modified the milestones: v1.6.0, v1.7.0-candidate Dec 9, 2019
@tstromberg tstromberg added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 9, 2019
@tstromberg tstromberg self-assigned this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/flake Categorizes issue or PR as related to a flaky test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant