Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize VM clocks at start time #4264

Closed
tstromberg opened this issue May 16, 2019 · 3 comments
Closed

Synchronize VM clocks at start time #4264

tstromberg opened this issue May 16, 2019 · 3 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. r/2019q2 Issue was last reviewed 2019q2

Comments

@tstromberg
Copy link
Contributor

Sometimes VM's may run into issues where their clocks fall behind the times. We should detect and fix when possible, and error when impossible.

See #4263 for context.

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 16, 2019
@tstromberg tstromberg changed the title Detect time-lagged VM's and fix or error out Synchronize VM clocks at start time May 16, 2019
@tstromberg tstromberg self-assigned this May 22, 2019
@GavinOsborn
Copy link

We run into this issue more often than we'd like. The APIs that we build and test accept various forms of Bearer tokens for authentication. Validation of these tokens often fails due to clock skew.

@tstromberg
Copy link
Contributor Author

tstromberg commented May 29, 2019

Fixed at head - will be part of next bug fix release.

@reegnz
Copy link
Contributor

reegnz commented Jun 13, 2019

Still experiencing the issue with minikube 1.1.1. See my comment in #1378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. r/2019q2 Issue was last reviewed 2019q2
Projects
None yet
Development

No branches or pull requests

3 participants