Addon enablement should be per-profile #4227
Labels
area/addons
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
Addons are global (maybe we should make them per instance?) - and gvisor enablement is only enabled if the container runtime backend is containerd. Unfortunately gvisor disablement is also subject to this check which is problematic as I can't turn off the gvisor addon, so all my minikube instances have the gvisor addon pod running and/or crashing by default. Should be a relatively easy fix.
As I'm thinking about this - I wonder if it makes sense at all to check whether the "current minikube instance" has containerd when the addon enablement is instance idependent?
The exact command to reproduce the issue:
minikube addons enable gvisor
on a containerd enabled minikubeminikube addons disable gvisor
The full output of the command that failed:
The operating system version: Linux
The text was updated successfully, but these errors were encountered: