Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon enablement should be per-profile #4227

Closed
balopat opened this issue May 8, 2019 · 1 comment · Fixed by #6124
Closed

Addon enablement should be per-profile #4227

balopat opened this issue May 8, 2019 · 1 comment · Fixed by #6124
Assignees
Labels
area/addons help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@balopat
Copy link
Contributor

balopat commented May 8, 2019

  1. Addons are global (maybe we should make them per instance?) - and gvisor enablement is only enabled if the container runtime backend is containerd. Unfortunately gvisor disablement is also subject to this check which is problematic as I can't turn off the gvisor addon, so all my minikube instances have the gvisor addon pod running and/or crashing by default. Should be a relatively easy fix.

  2. As I'm thinking about this - I wonder if it makes sense at all to check whether the "current minikube instance" has containerd when the addon enablement is instance idependent?

The exact command to reproduce the issue:

  1. minikube addons enable gvisor on a containerd enabled minikube
  2. minikube delete and recreate without containerd
  3. minikube addons disable gvisor
    The full output of the command that failed:
💣  disable failed: [This addon can only be enabled with the containerd runtime backend.

To enable this backend, please first stop minikube with:

minikube stop

and then start minikube again with the following flags:

minikube start --container-runtime=containerd --docker-opt containerd=/var/run/containerd/containerd.sock]

😿  Sorry that minikube crashed. If this was unexpected, we would love to hear from you:
👉  https://github.com/kubernetes/minikube/issues/new

The operating system version: Linux

@tstromberg tstromberg changed the title minikube addons disable gvisor Addons should be profile aware rather than global May 14, 2019
@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 14, 2019
@tstromberg tstromberg changed the title Addons should be profile aware rather than global Addon enablement should be per-profile May 14, 2019
@tstromberg tstromberg added the r/2019q2 Issue was last reviewed 2019q2 label May 24, 2019
@sharifelgamal sharifelgamal added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 18, 2019
@tstromberg tstromberg added this to the v1.5.0-candidate milestone Sep 9, 2019
@tstromberg
Copy link
Contributor

tstromberg commented Sep 9, 2019

Proposing for v1.5.0 because this behavior makes addon integration tests flaky and confuses users.

A perfect example is gvisor, which only starts in containerd.

@tstromberg tstromberg added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed r/2019q2 Issue was last reviewed 2019q2 kind/feature Categorizes issue or PR as related to a new feature. labels Sep 20, 2019
@tstromberg tstromberg modified the milestones: v1.5.0, v1.6.0-candidate Oct 14, 2019
@tstromberg tstromberg removed this from the v1.6.0-candidate milestone Oct 21, 2019
@tstromberg tstromberg added this to the v1.7.0 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addons help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants