Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast-path for restarting a cluster when the configuration is unchanged #4184

Closed
tstromberg opened this issue May 1, 2019 · 5 comments
Closed
Labels
area/performance Performance related issues help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@tstromberg
Copy link
Contributor

If the specified configuration is identical to the current configuration:

  • If VM is running, skip setup and block until pods are healthy. This should be instantanteous.
  • If VM is not running, start VM, reconfigure any IP's necessary, and block until pods are healthy.

#3293 was trying to solve this, but the logic to assert that the configuration was the same was never implemented. I feel that this would be a huge performance benefit for our users.

@tstromberg tstromberg added this to the v1.1.0 milestone May 1, 2019
@tstromberg tstromberg added area/performance Performance related issues priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. labels May 1, 2019
@tstromberg tstromberg removed this from the v1.1.0-candidate milestone May 1, 2019
@tstromberg tstromberg self-assigned this May 2, 2019
@tstromberg tstromberg added this to the v1.1.0 milestone May 6, 2019
@tstromberg tstromberg removed their assignment May 6, 2019
@tstromberg tstromberg removed this from the v1.1.0 milestone May 16, 2019
@tstromberg
Copy link
Contributor Author

Deferring for another release. Doing a prototype, I find that at best there is currently 20% savings for VM's not running, though a lot of savings if there is not.

One problem is that stopped VM's are rebooted at start :( I'm not sure if this is limited to libmachine or not.

@tstromberg tstromberg added r/2019q2 Issue was last reviewed 2019q2 priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 24, 2019
@sharifelgamal sharifelgamal added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 18, 2019
@tstromberg tstromberg removed the r/2019q2 Issue was last reviewed 2019q2 label Sep 20, 2019
@medyagh
Copy link
Member

medyagh commented Dec 16, 2019

having pause command will make the need to stop minikube less often

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 16, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 15, 2020
@tstromberg
Copy link
Contributor Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Performance related issues help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

5 participants