Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerd built for minikube reports it's version as a commit hash from buildroot #3454

Closed
ianlewis opened this issue Dec 14, 2018 · 3 comments
Labels
area/guest-vm General configuration issues with the minikube guest VM co/runtime/containerd help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@ianlewis
Copy link
Contributor

ianlewis commented Dec 14, 2018

Minikube version (use minikube version): 0.31.0

  • OS (e.g. from /etc/os-release): Ubuntu 16.04.5 LTS (Xenial Xerus)
  • VM Driver (e.g. cat ~/.minikube/machines/minikube/config.json | grep DriverName): kvm2
  • ISO version (e.g. cat ~/.minikube/machines/minikube/config.json | grep -i ISO or minikube ssh cat /etc/VERSION): 0.31.0
$ minikube ssh 'containerd -v'
containerd github.com/containerd/containerd f3d114a1ef f3d114a1effd8a6ef773bee14fe49ea6d8d7c350

buildroot/buildroot@f3d114a1ef

@tstromberg tstromberg added area/code-deps Code dependencies (guest-vm deps belong in guest-vm) area/guest-vm General configuration issues with the minikube guest VM co/runtime/containerd labels Dec 18, 2018
@afbjorklund
Copy link
Collaborator

@ianlewis
Copy link
Contributor Author

I'm sure there are reasons minikube builds from source, but is it out of the question to just use the containerd binary releases?

@afbjorklund
Copy link
Collaborator

Minikube uses binary releases for other software (like docker), it is a bit random at the moment.

It might even be so that the "-bin" in the package name originally referred to binary installations ?

Also the version seems a bit old, but I guess nobody uses containerd (preferring docker or cri-o)

https://github.com/containerd/containerd/releases

@tstromberg tstromberg added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed area/code-deps Code dependencies (guest-vm deps belong in guest-vm) labels Jan 22, 2019
@tstromberg tstromberg added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/guest-vm General configuration issues with the minikube guest VM co/runtime/containerd help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

3 participants