Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip kubeadm preflight checks #3320

Closed
maingoh opened this issue Nov 9, 2018 · 7 comments
Closed

Option to skip kubeadm preflight checks #3320

maingoh opened this issue Nov 9, 2018 · 7 comments
Labels
co/kubeadm Issues relating to kubeadm good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@maingoh
Copy link

maingoh commented Nov 9, 2018

FEATURE REQUEST

Since a new docker version has been released and is not validated, the preflight checks raise an error and prevent minikube to start. This would be nice if we could add a custom --ignore-preflight-errors to kubeadm, currently hardcoded here:

var Preflights = []string{

Also eventually override or remove the default ones depending on the environnement.

  • Minikube version: v0.28.2
  • OS : Ubuntu 18.04.1
  • VM Driver: none
@balopat balopat added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 14, 2018
@balopat
Copy link
Contributor

balopat commented Nov 14, 2018

This sounds like a good idea for advanced usage, since the issue is going to be around for a while.
cc #3323

@balopat balopat added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. co/kubeadm Issues relating to kubeadm labels Nov 14, 2018
@thomas-riccardi
Copy link

It's indeed related to #3323: the fix (kubernetes/kubernetes#71001) will probably only be included in kubernetes >= 1.13: since kubeadm provides a facility to ignore preflight errors there is no strict need to backport the fix to earlier kubernetes versions.

@afbjorklund
Copy link
Collaborator

Probably only valid for the "none" driver, since the various minikube.iso are supposed to pass checks.

Note that there are already quite a long list of "supported" ignores, such as that pesky old swap partition...

@tstromberg
Copy link
Contributor

FWIW, I'd be happy to review any PR which introduces this option.

@tstromberg tstromberg added priority/backlog Higher priority than priority/awaiting-more-evidence. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 23, 2019
@marcosdiez
Copy link
Contributor

@tstromberg your wishes came true. here is the PR: #3879

It actually allows one to pass generic commands to kubeadm

so this is what has to be executed:

sudo -E minikube start --vm-driver=none --kubernetes-version v1.11.8 --extra-config kubeadm.ignore-preflight-errors=SystemVerification

@jbcpollak
Copy link

For anyone running into issues with @marcosdiez 's solution, there is a small typo. You need to include an = as shown below:

sudo minikube start --vm-driver=none --extra-config=kubeadm.ignore-preflight-errors=SystemVerification

@tstromberg
Copy link
Contributor

This was fixed a while back: --extra-config kubeadm.ignore-preflight-errors=SystemVerification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/kubeadm Issues relating to kubeadm good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

7 participants