-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make test
failed on Mac
#2860
Comments
I'm unable to repro this on minikube at HEAD with go 1.10.1. There's no fmt.Println at line 322, which commit are you at? |
@dlorenc , thanks for checking out. I just synced my fork of the minikube code, and retested it. The original issue seems gone, I cannot reproduce it too. (by the way, it is not line 322 any longer since somebody checked in some more code later after I submitted the issue, it is line 339 of the new start.go now. Anyway, the problem is no longer there, weird.) With that being said, I encountered a new problem when I ran
|
I just created PR #2869 for this new problem. |
The root cause of this issue is that the current minikube dep So Kubernetes has a PR to update When will minikube be compatible with Go 1.10? Any plan? |
Localkube has been removed, we should be able to fix this now. |
@dlorenc thanks for the information. I will look into it in a day or two. Do you suggest to bump the golang support to 1.10, or instead just update |
OK. I will close it. Thanks @dlorenc |
@dlorenc , I looked into your #3014, seems for I reopen this issue till we have this problem figured out. |
Problem is resolved by removing |
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
This is a BUG
Please provide the following details:
Environment:
Minikube version (use
minikube version
): v0.27.0What happened:
make
works fine on Mac, but when runningmake test
, it shows the below error./test.sh
Running go tests...
# k8s.io/minikube/cmd/minikube/cmd
cmd/minikube/cmd/start.go:322: Println arg list ends with redundant newline
FAIL k8s.io/minikube/cmd/minikube/cmd [build failed]
make: *** [test] Error 2
The text was updated successfully, but these errors were encountered: