make test failed on Mac

[stantonxu]

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

This is a BUG

Please provide the following details:

Environment:
Minikube version (use minikube version): v0.27.0

• OS (e.g. from /etc/os-release): macOS 10.12.4 Sierra
• Others: Go 1.10.2

What happened:

make works fine on Mac, but when running make test, it shows the below error

./test.sh
Running go tests...
# k8s.io/minikube/cmd/minikube/cmd
cmd/minikube/cmd/start.go:322: Println arg list ends with redundant newline
FAIL k8s.io/minikube/cmd/minikube/cmd [build failed]
make: *** [test] Error 2

[dlorenc]

I'm unable to repro this on minikube at HEAD with go 1.10.1.

There's no fmt.Println at line 322, which commit are you at?
https://github.com/kubernetes/minikube/blob/master/cmd/minikube/cmd/start.go#L322

[stantonxu]

@dlorenc , thanks for checking out. I just synced my fork of the minikube code, and retested it. The original issue seems gone, I cannot reproduce it too. (by the way, it is not line 322 any longer since somebody checked in some more code later after I submitted the issue, it is line 339 of the new start.go now. Anyway, the problem is no longer there, weird.)

With that being said, I encountered a new problem when I ran make test just now. Here is the error.

# k8s.io/minikube/vendor/github.com/google/certificate-transparency/go/x509
vendor/github.com/google/certificate-transparency/go/x509/root_darwin.go:73: cannot use nil as type _Ctype_CFDataRef in assignment
FAIL	k8s.io/minikube/pkg/localkube [build failed]
make: *** [test] Error 2

[stantonxu]

I just created PR #2869 for this new problem.

[stantonxu]

The root cause of this issue is that the current minikube dep cfssl version is not compatible with Go 1.10, due to its dep google/certificate-transparency problem google/certificate-transparency-go#131

So make test succeeds with Go 1.9, but fails with Go 1.10

Kubernetes has a PR to update cfssl, kubernetes/kubernetes#60373

When will minikube be compatible with Go 1.10? Any plan?

[dlorenc]

Localkube has been removed, we should be able to fix this now.

[stantonxu]

@dlorenc thanks for the information. I will look into it in a day or two. Do you suggest to bump the golang support to 1.10, or instead just update cfssl vendor code and keep golang support with 1.9?

[dlorenc]

So I think we can close this issue and the PR, cfssl will be completely removed in #3014 then we can update to go 1.10 in #2777

[stantonxu]

OK. I will close it. Thanks @dlorenc

[stantonxu]

Closing the issue, duplicated with #2770, addressed by #2777

[stantonxu]

@dlorenc , I looked into your #3014, seems for cloudflare, you only removed the package log under cfssl, the other packages under cfssl are still there. It still has the dependency on google/certificate-transparency-go, so the make test will still fail.

I reopen this issue till we have this problem figured out.

[stantonxu]

Problem is resolved by removing cloudflare.