Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test failed on Mac #2860

Closed
stantonxu opened this issue May 31, 2018 · 11 comments
Closed

make test failed on Mac #2860

stantonxu opened this issue May 31, 2018 · 11 comments

Comments

@stantonxu
Copy link

stantonxu commented May 31, 2018

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

This is a BUG

Please provide the following details:

Environment:
Minikube version (use minikube version): v0.27.0

  • OS (e.g. from /etc/os-release): macOS 10.12.4 Sierra
  • Others: Go 1.10.2

What happened:

make works fine on Mac, but when running make test, it shows the below error

./test.sh
Running go tests...
# k8s.io/minikube/cmd/minikube/cmd
cmd/minikube/cmd/start.go:322: Println arg list ends with redundant newline
FAIL k8s.io/minikube/cmd/minikube/cmd [build failed]
make: *** [test] Error 2

@dlorenc
Copy link
Contributor

dlorenc commented Jun 4, 2018

I'm unable to repro this on minikube at HEAD with go 1.10.1.

There's no fmt.Println at line 322, which commit are you at?
https://github.com/kubernetes/minikube/blob/master/cmd/minikube/cmd/start.go#L322

@stantonxu
Copy link
Author

stantonxu commented Jun 4, 2018

@dlorenc , thanks for checking out. I just synced my fork of the minikube code, and retested it. The original issue seems gone, I cannot reproduce it too. (by the way, it is not line 322 any longer since somebody checked in some more code later after I submitted the issue, it is line 339 of the new start.go now. Anyway, the problem is no longer there, weird.)

With that being said, I encountered a new problem when I ran make test just now. Here is the error.

# k8s.io/minikube/vendor/github.com/google/certificate-transparency/go/x509
vendor/github.com/google/certificate-transparency/go/x509/root_darwin.go:73: cannot use nil as type _Ctype_CFDataRef in assignment
FAIL	k8s.io/minikube/pkg/localkube [build failed]
make: *** [test] Error 2

@stantonxu
Copy link
Author

I just created PR #2869 for this new problem.

@stantonxu
Copy link
Author

The root cause of this issue is that the current minikube dep cfssl version is not compatible with Go 1.10, due to its dep google/certificate-transparency problem google/certificate-transparency-go#131

So make test succeeds with Go 1.9, but fails with Go 1.10

Kubernetes has a PR to update cfssl, kubernetes/kubernetes#60373

When will minikube be compatible with Go 1.10? Any plan?

@dlorenc
Copy link
Contributor

dlorenc commented Jul 24, 2018

Localkube has been removed, we should be able to fix this now.

@stantonxu
Copy link
Author

@dlorenc thanks for the information. I will look into it in a day or two. Do you suggest to bump the golang support to 1.10, or instead just update cfssl vendor code and keep golang support with 1.9?

@dlorenc
Copy link
Contributor

dlorenc commented Jul 24, 2018

So I think we can close this issue and the PR, cfssl will be completely removed in #3014 then we can update to go 1.10 in #2777

@stantonxu
Copy link
Author

OK. I will close it. Thanks @dlorenc

@stantonxu
Copy link
Author

Closing the issue, duplicated with #2770, addressed by #2777

@stantonxu
Copy link
Author

@dlorenc , I looked into your #3014, seems for cloudflare, you only removed the package log under cfssl, the other packages under cfssl are still there. It still has the dependency on google/certificate-transparency-go, so the make test will still fail.

I reopen this issue till we have this problem figured out.

@stantonxu stantonxu reopened this Jul 25, 2018
@stantonxu
Copy link
Author

Problem is resolved by removing cloudflare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants