Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper-V modules need to be invoked with correct case #2639

Closed
gbraad opened this issue Mar 23, 2018 · 6 comments
Closed

Hyper-V modules need to be invoked with correct case #2639

gbraad opened this issue Mar 23, 2018 · 6 comments
Labels
co/hyperv HyperV related issues kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@gbraad
Copy link
Contributor

gbraad commented Mar 23, 2018

stdout, err := cmdOut("(", "hyper-v\\Get-VM", d.MachineName, ").state")
and others

this needed to be fixed with:

-	stdout, err := cmdOut("(", "hyper-v\\Get-VM", d.MachineName, ").state")
+	stdout, err := cmdOut("(", "Hyper-V\\Get-VM", d.MachineName, ").state")

else issues occured on the pre-create check

Full change can be seen in docker/machine#4426

@gbraad gbraad added kind/bug Categorizes issue or PR as related to a bug. co/hyperv HyperV related issues labels Mar 23, 2018
@gbraad
Copy link
Contributor Author

gbraad commented Mar 23, 2018

It is hard to track which version you actually have merged, but it seems it is somewhere after 0.14.0 ?

AFAIR this is only used in Docker for Windows/Mac edge releases. /cc: @dlorenc

@saitho
Copy link

saitho commented Mar 23, 2018

The bugfix in docker-machine is currently only in the master branch and has not been released in a version yet... I'm currently getting the error "Hyper-V PowerShell Module is not available" when I'm trying to start Minikube (for the first time) on my Windows computer with Hyper-V enabled.

I compiled docker-machine from the master branch, but still can't start up Minikube. ^^ (The issue described on the docker-machine project works fine now).

@saitho
Copy link

saitho commented Mar 23, 2018

I solved the issue locally and recompiled minikube. Seems to work fine now.
However I did not decide to open a PR for that as I'm pretty new to Go and I have no idea about how dependency management exactly works... For now I just adjusted the files in the vendor/ directory. ^^

I can confirm that the problem described in #2634 is solved with that. I was able to start Minikube successfully on my Windows computer with Hyper-V enabled.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 21, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/hyperv HyperV related issues kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants