Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ValidatingAdmissionWebhook and MutatingAdmissionWebhook in default bootstrapper #2583

Closed
the-redback opened this issue Mar 1, 2018 · 3 comments
Closed

Enable ValidatingAdmissionWebhook and MutatingAdmissionWebhook in default bootstrapper #2583

the-redback opened this issue Mar 1, 2018 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@the-redback
Copy link

the-redback commented Mar 1, 2018 •
edited
Loading

FEATURE REQUEST

Right now we need to add --extra-config=... flag to enable ValidatingAdmissionWebhook and MutatingAdmissionWebhook.

Since 1.9+, both of these admission controllers are in beta, minikube should have them enabled in default bootstrapper, minikube start.
@the-redback the-redback changed the title Enable ValidatingAdmissionWebhook and MutatingAdmissionWebhook by default Enable ValidatingAdmissionWebhook and MutatingAdmissionWebhook in default bootstrapper Mar 1, 2018
@the-redback
Copy link
Author

cc: @r2d4 @tamalsaha

@r2d4 r2d4 added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 5, 2018
@r2d4
Copy link
Contributor

r2d4 commented Mar 5, 2018

SGTM

@dlorenc
Copy link
Contributor

dlorenc commented Mar 5, 2018

I added the mutating one in #2547

@dlorenc dlorenc mentioned this issue Mar 6, 2018
Merged
@tcnghia tcnghia mentioned this issue May 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@r2d4 @dlorenc @the-redback