Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cri-o sock to default, as per upstream #2261

Closed
surajssd opened this issue Dec 2, 2017 · 0 comments
Closed

Change cri-o sock to default, as per upstream #2261

surajssd opened this issue Dec 2, 2017 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@surajssd
Copy link
Member

surajssd commented Dec 2, 2017

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

/kind Feature request/change

Please provide the following details:

Environment:

minikube version: v0.24.1

OS:
NAME=Fedora
VERSION="25 (Workstation Edition)"
ID=fedora
VERSION_ID=25
PRETTY_NAME="Fedora 25 (Workstation Edition)"
ANSI_COLOR="0;34"
CPE_NAME="cpe:/o:fedoraproject:fedora:25"
HOME_URL="https://fedoraproject.org/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=25
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=25
PRIVACY_POLICY_URL=https://fedoraproject.org/wiki/Legal:PrivacyPolicy
VARIANT="Workstation Edition"
VARIANT_ID=workstation

VM driver:
    "DriverName": "kvm",

ISO version
        "ISO": "/home/fedora/.minikube/machines/minikube/boot2docker.iso",
        "Boot2DockerURL": "file:///home/fedora/.minikube/cache/iso/minikube-v0.23.6.iso",

What happened:

Change all the cri-o socket path to the default as the upstream suggests. Right now cri-o socket is placed or created in /var/run/crio.sock, while upstream suggests/defaults to place it in /var/run/crio/crio.sock.

What you expected to happen:

cri-o socket should be placed in /var/run/crio/crio.sock

How to reproduce it (as minimally and precisely as possible):

$ minikube start \
     --network-plugin=cni \
     --extra-config=kubelet.container-runtime=remote \
     --extra-config=kubelet.container-runtime-endpoint=/var/run/crio.sock \
     --extra-config=kubelet.image-service-endpoint=/var/run/crio.sock --cpus=4 --memory 6000 --vm-driver=kvm \
     --bootstrapper=kubeadm

$ minikube ssh

Inside the VM you will find the socket

$ sudo find / -samefile /var/run/crio.sock 2>/dev/null
/run/crio.sock
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants