Brew Formula for Minikube

[r2d4]

Is this a BUG REPORT or FEATURE REQUEST? (choose one): feature request

We currently have a brew cask installer, which installs from a pre-built binary. However, we can create a real brew formula for minikube now that we no longer include (and therefore don't cross build) localkube with go-bindata.

I think the formula should be pretty straightforward and would be very similar to existing go formula.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[brgnepal]

@r2d4 , I think we can close this issue right?
I can see cask file https://github.com/caskroom/homebrew-cask/blob/master/Casks/minikube.rb .

[r2d4]

Currently the cask just downloads the prebuilt binary. Now that we don't package localkube anymore, we can just build from source and have a real brew formula instead of just a cask.

[ymesika]

If no one is working on creating a build formulae I can propose myself as an assignee.. Have a recent experience generating a formulae for another tool.

[tstromberg]

Still needed.

[afbjorklund]

Still needed.

Currently we ship the same Linux binary everywhere: raw, tgz, deb, rpm

We might do the same for Darwin, that is leave it as a brew "cask" (binary)

[plod]

it okay if I have a crack at this?

[medyagh]

it okay if I have a crack at this?

yes you could have this issue ! :)

[commitay]

I've opened a PR for a minikube formula: Homebrew/homebrew-core#45603

[tstromberg]

Before we close this, we'll need to insure that our release scripts release to brew rather than cask:

• https://github.com/kubernetes/minikube/blob/master/hack/jenkins/release_update_brew.sh
• https://github.com/kubernetes/minikube/blob/master/installers/darwin/brew-cask/minikube.rb.tmpl

@commitay @issyl0 - are either of you interested in taking a crack at updating our release scripts?

[afbjorklund]

I thought distros was supposed to pull (new releases) rather than push (from vendor) ? Especially if it is no longer our binary, but something they build. But not sure how Brew normally operates.

[issyl0]

@tstromberg I don't currently have enough spare time to help with this bigger piece of work, sorry!