Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inner docker systemd service: move 'StartLimitIntervalSec' param from [Service] to [Unit] section #10410

Closed
prezha opened this issue Feb 8, 2021 · 2 comments · Fixed by #10411
Closed

inner docker systemd service: move 'StartLimitIntervalSec' param from [Service] to [Unit] section #10410

prezha opened this issue Feb 8, 2021 · 2 comments · Fixed by #10411
Assignees
@prezha
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@prezha
Copy link
Contributor

prezha commented Feb 8, 2021

repeating errors shown in logs:

Feb 07 01:57:49 functional-20210207015702-1428035 systemd[1]: /lib/systemd/system/docker.service:13: Unknown key name 'StartLimitIntervalSec' in section 'Service', ignoring.

advising that the StartLimitIntervalSec param is ignored

this param was used for resolving issue #9691 in pr #9775
i've been also checking it, but missed the conversation discussing the changes in systemd (ref: https://lists.freedesktop.org/archives/systemd-devel/2017-July/039255.html):

"StartLimitInterval was moved from [Service] to [Unit] section in 6bf0f408e4833152197fb38fb10a9989c89f3a59, but the old location was still accepted for compatibility. The new StartLimitIntervalSec name is valid only in [Unit]."

indeed: systemd/systemd@6bf0f40

so, I'm creating a pr to move StartLimit* param from [Service] to [Unit] section and eliminate this error
@prezha
Copy link
Contributor Author

prezha commented Feb 8, 2021

/assign

@prezha prezha mentioned this issue Feb 8, 2021
Merged
@medyagh
Copy link
Member

medyagh commented Feb 8, 2021

@prezha good idea thanks for fixing it

@medyagh medyagh added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prezha prezha

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move StartLimitIntervalSec param from [Service] to [Unit] section prezha/minikube
2 participants
@medyagh @prezha