Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fix and write tests for Snap package manager bug #10407

Closed
spowelljr opened this issue Feb 8, 2021 · 3 comments · Fixed by #10372
Closed

Create fix and write tests for Snap package manager bug #10407

spowelljr opened this issue Feb 8, 2021 · 3 comments · Fixed by #10372
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@spowelljr
Copy link
Member

spowelljr commented Feb 8, 2021

Background info:
The original issue was that starting minikube installed via Snap (package manager) would result in the error:

prepare kic ssh: copying pub key: docker copy /tmp/tmpf-memory-asset150446131 into minikube:/home/docker/.ssh/authorized_keys, output: lstat /tmp/tmpf-memory-asset150446131: no such file or directory
This is due to Snap only allowing packages to see their own view of the /tmp folder.

In this case minikube copies a memory asset to the /tmp folder for Docker to later copy. Snap prevents Docker from seeing minikubes file and the above error occurs.

This issue was attempted to be fixed in #10042, the correct way to solve this issue is to check if the binary is installed via Snap, and if it is, writes the memory asset to the users home directory instead. However, there was a bug included in the PR where instead of setting the tmp directory to the users home directory, it would try to find an env variable by the name of the users home directory and set that as the tmp directory. This env was not found and would return an empty string, passing an empty string to the function would fallback to using the default tmp directory and would fail.

@spowelljr spowelljr added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 8, 2021
@spowelljr spowelljr added this to the v1.18.0 milestone Feb 8, 2021
@spowelljr spowelljr self-assigned this Feb 8, 2021
@spowelljr
Copy link
Member Author

In-progress

@afbjorklund
Copy link
Collaborator

afbjorklund commented Feb 9, 2021

@spowelljr : This issue description is quite vague, but I guess one can guess what it was supposed to do from the PR description

@spowelljr
Copy link
Member Author

spowelljr commented Feb 10, 2021

@afbjorklund I updated the issue description with the PR description, hopefully that helps. Thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants