Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node list command not print all nodes. #10069

Closed
daehyeok opened this issue Dec 30, 2020 · 3 comments
Closed

node list command not print all nodes. #10069

daehyeok opened this issue Dec 30, 2020 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@daehyeok
Copy link
Contributor

daehyeok commented Dec 30, 2020

minikube node list command only print nodes in default profile. It should print all nodes regardless of their profile.
Also, Implement additional argument to filter nodes by profile name will be good.

❯ minikube profile list
|--------------|-----------|---------|--------------|------|---------|---------|-------|
|   Profile    | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes |
|--------------|-----------|---------|--------------|------|---------|---------|-------|
| minikube     | docker    | docker  | 192.168.49.2 | 8443 | v1.20.0 | Stopped |     2 |
| test-profile | docker    | docker  | 192.168.49.2 | 8443 | v1.20.0 | Running |     2 |
|--------------|-----------|---------|--------------|------|---------|---------|-------|
❗  Found 2 invalid profile(s) !
         test-profile-m02
         minikube-m02
💡  You can delete them using the following command(s):
         $ minikube delete -p test-profile-m02
         $ minikube delete -p minikube-m02
❯ minikube node list
minikube        192.168.49.2
minikube-m02    192.168.49.3
@tstromberg tstromberg added the triage/discuss Items for discussion label Jan 6, 2021
@tstromberg
Copy link
Contributor

I personally don't agree with this. Most commands are specific to a profile, by design. Will bring this up for discussion at the triage meeting today.

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Jan 6, 2021
@medyagh
Copy link
Member

medyagh commented Jan 6, 2021

I think minikube is doing the right thing here, since -p is an implicit flag that is being passed,
what you are seeing is, the list for

minikube node list -p minikube

I dont think we should list nodes outside your cluster.
this behaviour is in sync with kubectl,
if you do "kubectl get nodes"

@medyagh medyagh removed the triage/discuss Items for discussion label Jan 6, 2021
@medyagh
Copy link
Member

medyagh commented Jan 6, 2021

btw in the first part of the issue there is a bug that there is a WIP for that #9996

I am going to close this issue, please feel free to re-open if you have more quesitons.

@medyagh medyagh closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

3 participants