Code review feedback.

dlorenc · dlorenc · commit e672b244f853 · 2018-06-28T07:40:36.000-07:00
diff --git a/pkg/minikube/bootstrapper/kubeadm/versions.go b/pkg/minikube/bootstrapper/kubeadm/versions.go
@@ -205,7 +205,7 @@ var versionSpecificOpts = []VersionedExtraOption{
 			Key:       "admission-control",
 			Value:     strings.Join(util.DefaultAdmissionControllers, ","),
 		},
-		LessThanOrEqual:    semver.MustParse("1.10.10"),
+		LessThanOrEqual:    semver.MustParse("1.10.1000"), // Semver doesn't support wildcards.
 		GreaterThanOrEqual: semver.MustParse("1.9.0-alpha.0"),
 	},
 	{

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ var versionSpecificOpts = []VersionedExtraOption{`
`205`	`205`	`Key: "admission-control",`
`206`	`206`	`Value: strings.Join(util.DefaultAdmissionControllers, ","),`
`207`	`207`	`},`
`208`		`- LessThanOrEqual: semver.MustParse("1.10.10"),`
	`208`	`+ LessThanOrEqual: semver.MustParse("1.10.1000"), // Semver doesn't support wildcards.`
`209`	`209`	`GreaterThanOrEqual: semver.MustParse("1.9.0-alpha.0"),`
`210`	`210`	`},`
`211`	`211`	`{`