Skip to content

Commit a7489c1

Browse files
authored
Merge pull request #10309 from afbjorklund/ssh-address
Make sure that ssh driver gets an ip address
2 parents dec27e3 + 2120640 commit a7489c1

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

cmd/minikube/cmd/start.go

+14
Original file line numberDiff line numberDiff line change
@@ -1118,6 +1118,20 @@ func validateFlags(cmd *cobra.Command, drvName string) {
11181118
}
11191119
}
11201120

1121+
if driver.IsSSH(drvName) {
1122+
sshIPAddress := viper.GetString(sshIPAddress)
1123+
if sshIPAddress == "" {
1124+
exit.Message(reason.Usage, "No IP address provided. Try specifying --ssh-ip-address, or see https://minikube.sigs.k8s.io/docs/drivers/ssh/")
1125+
}
1126+
1127+
if net.ParseIP(sshIPAddress) == nil {
1128+
_, err := net.LookupIP(sshIPAddress)
1129+
if err != nil {
1130+
exit.Error(reason.Usage, "Could not resolve IP address", err)
1131+
}
1132+
}
1133+
}
1134+
11211135
// validate kubeadm extra args
11221136
if invalidOpts := bsutil.FindInvalidExtraConfigFlags(config.ExtraOptions); len(invalidOpts) > 0 {
11231137
out.WarningT(

0 commit comments

Comments
 (0)