Skip to content

Commit a2999d9

Browse files
committed
none reliability: --force does not work in v1.10, allow failed kubelet
1 parent 5d325c7 commit a2999d9

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

Diff for: pkg/drivers/none/none.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,8 @@ func stopKubelet(exec command.Runner) error {
233233
if errStatus != nil {
234234
glog.Errorf("temporary error: for %q : %v", cmdCheck, errStatus)
235235
}
236-
if !strings.Contains(out.String(), "dead") {
237-
return fmt.Errorf("expected to kubelet to be dead but it got : %q", out)
236+
if !strings.Contains(out.String(), "dead") && if !strings.Contains(out.String(), "failed") {
237+
return fmt.Errorf("unexpected kubelet state: %q", out)
238238
}
239239
return nil
240240
}

Diff for: pkg/minikube/bootstrapper/kubeadm/kubeadm.go

+3
Original file line numberDiff line numberDiff line change
@@ -457,6 +457,9 @@ func (k *Bootstrapper) waitForAPIServer(k8s config.KubernetesConfig) error {
457457
// DeleteCluster removes the components that were started earlier
458458
func (k *Bootstrapper) DeleteCluster(k8s config.KubernetesConfig) error {
459459
cmd := fmt.Sprintf("%s reset --force", invokeKubeadm(k8s.KubernetesVersion))
460+
if version.LT(semver.MustParse("1.11.0")) {
461+
cmd := fmt.Sprintf("%s reset", invokeKubeadm(k8s.KubernetesVersion))
462+
}
460463
out, err := k.c.CombinedOutput(cmd)
461464
if err != nil {
462465
return errors.Wrapf(err, "kubeadm reset: %s\n%s\n", cmd, out)

0 commit comments

Comments
 (0)