From 0c43340221cb3acd3fb1c9b464f618672e264be6 Mon Sep 17 00:00:00 2001 From: Josh Woodcock Date: Fri, 4 Oct 2019 09:38:11 -0500 Subject: [PATCH 1/3] Add instructions for including supporting documents with MEP proposal --- enhancements/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/enhancements/README.md b/enhancements/README.md index a0a648048932..590f00546089 100644 --- a/enhancements/README.md +++ b/enhancements/README.md @@ -6,7 +6,7 @@ MEP is based on a simplification of the [Kubernetes Enhancement Process](https:/ ## Workflow -1. Copy `template.md` to `proposed/-title.md` +1. Copy `template.md` to `proposed/-title.md` or `proposed/-title/README.md` in case you need to include supporting documents. If you include supporting documents place them in the `proposed/-title/` directory. 1. Send PR out for review, titled: `Proposal: ` 1. Proposal will be discussed at the bi-weekly minikube office hours 1. After a 2-week review window, the proposal can be merged once there are 3 approving maintainers or reviewers. To keep proposals neutral, each reviewer must be independent and/or represent a different company. From 307ea63f165146baf4b575bde1891fb6ef121fb4 Mon Sep 17 00:00:00 2001 From: Josh Woodcock <joshwoodcock@beagile.biz> Date: Fri, 4 Oct 2019 13:29:42 -0500 Subject: [PATCH 2/3] Change 'Proposal' to 'MEP' in enhancements instructions --- enhancements/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/enhancements/README.md b/enhancements/README.md index 590f00546089..5943f3b95ea3 100644 --- a/enhancements/README.md +++ b/enhancements/README.md @@ -7,7 +7,7 @@ MEP is based on a simplification of the [Kubernetes Enhancement Process](https:/ ## Workflow 1. Copy `template.md` to `proposed/<date>-title.md` or `proposed/<date>-title/README.md` in case you need to include supporting documents. If you include supporting documents place them in the `proposed/<date>-title/` directory. -1. Send PR out for review, titled: `Proposal: <title>` +1. Send PR out for review, titled: `MEP: <title>` 1. Proposal will be discussed at the bi-weekly minikube office hours 1. After a 2-week review window, the proposal can be merged once there are 3 approving maintainers or reviewers. To keep proposals neutral, each reviewer must be independent and/or represent a different company. 1. In your PR that implements the enhancement, move the proposal to the `implemented/` folder. From d0a7f19c25d553e9e69dc8f0f4d98bef7fa100c5 Mon Sep 17 00:00:00 2001 From: Josh Woodcock <joshwoodcock@beagile.biz> Date: Wed, 16 Oct 2019 09:19:41 -0500 Subject: [PATCH 3/3] Use directories instead of file names for all MEP's --- enhancements/README.md | 4 ++-- .../README.md} | 0 2 files changed, 2 insertions(+), 2 deletions(-) rename enhancements/implemented/{20190925-minikube-enhancement-process.md => 20190925-minikube-enhancement-process/README.md} (100%) diff --git a/enhancements/README.md b/enhancements/README.md index 5943f3b95ea3..5c6ef799a730 100644 --- a/enhancements/README.md +++ b/enhancements/README.md @@ -1,12 +1,12 @@ # Enhancements -The *minikube enhancement process (MEP)* is a way to propose, communicate, and coordinate on new efforts for the minikube project. You can read the full details in the (MEP proposal)[proposed/20190925-minikube-enhancement-process.md] +The *minikube enhancement process (MEP)* is a way to propose, communicate, and coordinate on new efforts for the minikube project. You can read the full details in the [MEP proposal](implemented/20190925-minikube-enhancement-process/README.md) MEP is based on a simplification of the [Kubernetes Enhancement Process](https://github.com/kubernetes/enhancements/blob/master/keps/0001-kubernetes-enhancement-proposal-process.md). ## Workflow -1. Copy `template.md` to `proposed/<date>-title.md` or `proposed/<date>-title/README.md` in case you need to include supporting documents. If you include supporting documents place them in the `proposed/<date>-title/` directory. +1. Copy `template.md` to `proposed/<date>-title/README.md`. Include supporting documents in the `proposed/<date>-title/` directory. 1. Send PR out for review, titled: `MEP: <title>` 1. Proposal will be discussed at the bi-weekly minikube office hours 1. After a 2-week review window, the proposal can be merged once there are 3 approving maintainers or reviewers. To keep proposals neutral, each reviewer must be independent and/or represent a different company. diff --git a/enhancements/implemented/20190925-minikube-enhancement-process.md b/enhancements/implemented/20190925-minikube-enhancement-process/README.md similarity index 100% rename from enhancements/implemented/20190925-minikube-enhancement-process.md rename to enhancements/implemented/20190925-minikube-enhancement-process/README.md