Skip to content

Commit

Permalink
Merge pull request #9988 from daehyeok/wait_binary
Browse files Browse the repository at this point in the history
Performance bot wait for binary before run
  • Loading branch information
priyawadhwa committed Jan 6, 2021
2 parents cb7e09b + f3a5ac4 commit 95c92eb
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion pkg/minikube/perf/binary.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,13 @@ import (
"runtime"
"strconv"
"strings"
"time"

"cloud.google.com/go/storage"
"github.com/pkg/errors"
"google.golang.org/api/option"
"k8s.io/minikube/pkg/minikube/constants"
"k8s.io/minikube/pkg/util/retry"
)

// Binary holds a minikube binary
Expand Down Expand Up @@ -109,9 +111,11 @@ func newBinaryFromPR(pr string) (*Binary, error) {
path: localMinikubePath(i),
pr: i,
}
if err := b.download(); err != nil {

if err := retry.Expo(b.download, 1*time.Minute, 10*time.Minute); err != nil {
return nil, errors.Wrapf(err, "downloading binary")
}

return b, nil
}

Expand Down

0 comments on commit 95c92eb

Please sign in to comment.