Skip to content

Commit 95171be

Browse files
authored
Merge pull request #7751 from kubernetes/revert-7724-kubeadm-reset-cri-socket
Revert "Pass the cri socket path to kubeadm reset command"
2 parents b0378e9 + d380113 commit 95171be

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

pkg/minikube/bootstrapper/kubeadm/kubeadm.go

+7-9
Original file line numberDiff line numberDiff line change
@@ -572,21 +572,14 @@ func (k *Bootstrapper) GenerateToken(cc config.ClusterConfig) (string, error) {
572572

573573
// DeleteCluster removes the components that were started earlier
574574
func (k *Bootstrapper) DeleteCluster(k8s config.KubernetesConfig) error {
575-
cr, err := cruntime.New(cruntime.Config{Type: k8s.ContainerRuntime, Runner: k.c, Socket: k8s.CRISocket})
576-
if err != nil {
577-
return errors.Wrap(err, "runtime")
578-
}
579-
580575
version, err := util.ParseKubernetesVersion(k8s.KubernetesVersion)
581576
if err != nil {
582577
return errors.Wrap(err, "parsing kubernetes version")
583578
}
584579

585-
ka := bsutil.InvokeKubeadm(k8s.KubernetesVersion)
586-
sp := cr.SocketPath()
587-
cmd := fmt.Sprintf("%s reset --cri-socket %s --force", ka, sp)
580+
cmd := fmt.Sprintf("%s reset --force", bsutil.InvokeKubeadm(k8s.KubernetesVersion))
588581
if version.LT(semver.MustParse("1.11.0")) {
589-
cmd = fmt.Sprintf("%s reset --cri-socket %s", ka, sp)
582+
cmd = fmt.Sprintf("%s reset", bsutil.InvokeKubeadm(k8s.KubernetesVersion))
590583
}
591584

592585
rr, derr := k.c.RunCmd(exec.Command("/bin/bash", "-c", cmd))
@@ -598,6 +591,11 @@ func (k *Bootstrapper) DeleteCluster(k8s config.KubernetesConfig) error {
598591
glog.Warningf("stop kubelet: %v", err)
599592
}
600593

594+
cr, err := cruntime.New(cruntime.Config{Type: k8s.ContainerRuntime, Runner: k.c, Socket: k8s.CRISocket})
595+
if err != nil {
596+
return errors.Wrap(err, "runtime")
597+
}
598+
601599
containers, err := cr.ListContainers(cruntime.ListOptions{Namespaces: []string{"kube-system"}})
602600
if err != nil {
603601
glog.Warningf("unable to list kube-system containers: %v", err)

0 commit comments

Comments
 (0)