From ea1331619a8b43a84a627df944caa2e69aff6b51 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:12:09 -0700 Subject: [PATCH 01/16] add setup-minikube in github actions tutorial --- .../use_minikube_in_github_acrtions.md | 116 ++++++++++++++++++ 1 file changed, 116 insertions(+) create mode 100644 site/content/en/docs/tutorials/use_minikube_in_github_acrtions.md diff --git a/site/content/en/docs/tutorials/use_minikube_in_github_acrtions.md b/site/content/en/docs/tutorials/use_minikube_in_github_acrtions.md new file mode 100644 index 000000000000..9c18d4638cab --- /dev/null +++ b/site/content/en/docs/tutorials/use_minikube_in_github_acrtions.md @@ -0,0 +1,116 @@ +--- +title: "use minikube as CI testing in github actions" +linkTitle: "minikube in github actions" +weight: 1 +date: 2020-06-02 +description: > + How to use minikube in github actions for testing ? +--- + +### How to run minikube in github acitons ? + +you can add [setup-minikube](https://github.com/marketplace/actions/setup-minikube) as a step in your workflow. + +To install and start a minikube cluster, add the following step to your [github action workflow](https://help.github.com/en/actions/configuring-and-managing-workflows/configuring-a-workflow). + +```yaml + steps: + - name: start minikube + id: minikube + uses: medyagh/setup-minikube@master +``` + +## Full example: build image and deploy to minikube on each PR + +Required : + +- a valid Dockerfile +- a valid deployment.yaml (make sure image pull policy is set to never see bellow for example + +- Copy the yaml to `.github/workflows/pr.yml` in your github repo. +- Make a PR to your repo and see the result in github actions. + +```yaml +name: CI +on: + - pull_request +jobs: + job1: + runs-on: ubuntu-latest + name: build example and deploy to minikbue + steps: + - uses: actions/checkout@v2 + - name: Start minikube + uses: medyagh/setup-minikube@master + - name: Try the cluster ! + run: kubectl get pods -A + - name: Build image + run: | + export SHELL=/bin/bash + eval $(minikube -p minikube docker-env) + docker build -f ./Dockerfile -t local/example1 . + echo -n "verifying images:" + docker images + - name: Deploy to minikube + run: + kubectl apply -f deploy-to-minikube.yaml + - name: Test service URLs + run: | + minikube service list + minikube service example --url + echo "------------------opening the service------------------" + curl $(minikube service example --url)/version +``` + +In this example, the above workflow yaml, will do the following steps on each coming PR: + +1- Checks out the the source code +2- Installs and starts minikube +3- Trying out the cluster just by running kubectl get pods -A +4- Build the docker image using minikube's docker-env feature +5- Apply the yaml deployment yaml file minikube +6- Check the service been created in minikube + +### example deployment yaml for minikube + +```yaml +apiVersion: apps/v1 +kind: Deployment +metadata: + name: example +spec: + selector: + matchLabels: + app: example + replicas: 2 + template: + metadata: + labels: + app: example + spec: + containers: + - name: example-api + imagePullPolicy: Never + image: local/example:latest + resources: + limits: + cpu: 50m + memory: 100Mi + requests: + cpu: 25m + memory: 10Mi + ports: + - containerPort: 8080 +--- +apiVersion: v1 +kind: Service +metadata: + name: example +spec: + type: NodePort + selector: + app: example + ports: + - port: 8080 + targetPort: 8080 +``` From 56ccfd6e678f31a8d8239f6d81c6a5e6227f445f Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:12:50 -0700 Subject: [PATCH 02/16] improve description --- .../en/docs/tutorials/use_minikube_in_github_acrtions.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/site/content/en/docs/tutorials/use_minikube_in_github_acrtions.md b/site/content/en/docs/tutorials/use_minikube_in_github_acrtions.md index 9c18d4638cab..70e042fe9a47 100644 --- a/site/content/en/docs/tutorials/use_minikube_in_github_acrtions.md +++ b/site/content/en/docs/tutorials/use_minikube_in_github_acrtions.md @@ -1,10 +1,10 @@ --- -title: "use minikube as CI testing in github actions" +title: "Setup minikube as CI step in github actions" linkTitle: "minikube in github actions" weight: 1 date: 2020-06-02 description: > - How to use minikube in github actions for testing ? + How to use minikube in github actions for testing your app? --- ### How to run minikube in github acitons ? From e90c8defbaf8e6fe5bea5b80a7037e544fd9b13d Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:15:12 -0700 Subject: [PATCH 03/16] fix typo --- ...n_github_acrtions.md => setup_minikube_in_github_actions.md} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename site/content/en/docs/tutorials/{use_minikube_in_github_acrtions.md => setup_minikube_in_github_actions.md} (98%) diff --git a/site/content/en/docs/tutorials/use_minikube_in_github_acrtions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md similarity index 98% rename from site/content/en/docs/tutorials/use_minikube_in_github_acrtions.md rename to site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index 70e042fe9a47..09ac583f6954 100644 --- a/site/content/en/docs/tutorials/use_minikube_in_github_acrtions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -48,7 +48,7 @@ jobs: run: | export SHELL=/bin/bash eval $(minikube -p minikube docker-env) - docker build -f ./Dockerfile -t local/example1 . + docker build -f ./Dockerfile -t local/example . echo -n "verifying images:" docker images - name: Deploy to minikube From 65a4a94a092a53b1aa33761aabb26619f86e729c Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:15:59 -0700 Subject: [PATCH 04/16] fix typo --- .../en/docs/tutorials/setup_minikube_in_github_actions.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index 09ac583f6954..3a71e6a60557 100644 --- a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -22,12 +22,14 @@ To install and start a minikube cluster, add the following step to your [github ## Full example: build image and deploy to minikube on each PR -Required : +Requirements: - a valid Dockerfile - a valid deployment.yaml (make sure image pull policy is set to never see bellow for example -- Copy the yaml to `.github/workflows/pr.yml` in your github repo. +Steps: + +- Copy the wokryaml to `.github/workflows/pr.yml` in your github repo. - Make a PR to your repo and see the result in github actions. ```yaml From e71bd9a1c132be1fe49718501df896cc96cdea74 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:19:24 -0700 Subject: [PATCH 05/16] improve --- .../en/docs/tutorials/setup_minikube_in_github_actions.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index 3a71e6a60557..9fd3e8c9723e 100644 --- a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -7,12 +7,9 @@ description: > How to use minikube in github actions for testing your app? --- -### How to run minikube in github acitons ? - -you can add [setup-minikube](https://github.com/marketplace/actions/setup-minikube) as a step in your workflow. - To install and start a minikube cluster, add the following step to your [github action workflow](https://help.github.com/en/actions/configuring-and-managing-workflows/configuring-a-workflow). + ```yaml steps: - name: start minikube @@ -20,6 +17,9 @@ To install and start a minikube cluster, add the following step to your [github uses: medyagh/setup-minikube@master ``` +for more information checkout github actions marketplace :[setup-minikube](https://github.com/marketplace/actions/setup-minikube). + + ## Full example: build image and deploy to minikube on each PR Requirements: From 481e9acf55912a87293e9b8cafdfcbad594d1f21 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:19:58 -0700 Subject: [PATCH 06/16] improve --- .../en/docs/tutorials/setup_minikube_in_github_actions.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index 9fd3e8c9723e..16e0913a89bf 100644 --- a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -19,8 +19,7 @@ To install and start a minikube cluster, add the following step to your [github for more information checkout github actions marketplace :[setup-minikube](https://github.com/marketplace/actions/setup-minikube). - -## Full example: build image and deploy to minikube on each PR +## Example: build image & deploy to minikube on each PR Requirements: From c63dea7db3bca28e5b69814e45c390a2a91e0e29 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:26:38 -0700 Subject: [PATCH 07/16] improve link --- .../setup_minikube_in_github_actions.md | 81 +++++++++---------- 1 file changed, 40 insertions(+), 41 deletions(-) diff --git a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index 16e0913a89bf..a71668b2d67a 100644 --- a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -24,55 +24,54 @@ for more information checkout github actions marketplace :[setup-minikube](https Requirements: - a valid Dockerfile -- a valid deployment.yaml (make sure image pull policy is set to never see bellow for example +- a valid deployment.yaml to deploy image to kubernetes (make sure image pull policy is set to never see [bellow](/#deployment.yaml used in the example) for example) Steps: -- Copy the wokryaml to `.github/workflows/pr.yml` in your github repo. -- Make a PR to your repo and see the result in github actions. +- Create a workflow yaml in your github repo in `.github/workflows/pr.yml` -```yaml -name: CI -on: - - pull_request -jobs: - job1: - runs-on: ubuntu-latest - name: build example and deploy to minikbue - steps: - - uses: actions/checkout@v2 - - name: Start minikube - uses: medyagh/setup-minikube@master - - name: Try the cluster ! - run: kubectl get pods -A - - name: Build image - run: | - export SHELL=/bin/bash - eval $(minikube -p minikube docker-env) - docker build -f ./Dockerfile -t local/example . - echo -n "verifying images:" - docker images - - name: Deploy to minikube - run: - kubectl apply -f deploy-to-minikube.yaml - - name: Test service URLs - run: | - minikube service list - minikube service example --url - echo "------------------opening the service------------------" - curl $(minikube service example --url)/version -``` + ```yaml + name: CI + on: + - pull_request + jobs: + job1: + runs-on: ubuntu-latest + name: build example and deploy to minikbue + steps: + - uses: actions/checkout@v2 + - name: Start minikube + uses: medyagh/setup-minikube@master + - name: Try the cluster ! + run: kubectl get pods -A + - name: Build image + run: | + export SHELL=/bin/bash + eval $(minikube -p minikube docker-env) + docker build -f ./Dockerfile -t local/example . + echo -n "verifying images:" + docker images + - name: Deploy to minikube + run: + kubectl apply -f deploy-to-minikube.yaml + - name: Test service URLs + run: | + minikube service list + minikube service example --url + echo "------------------opening the service------------------" + curl $(minikube service example --url)/version + ``` In this example, the above workflow yaml, will do the following steps on each coming PR: -1- Checks out the the source code -2- Installs and starts minikube -3- Trying out the cluster just by running kubectl get pods -A -4- Build the docker image using minikube's docker-env feature -5- Apply the yaml deployment yaml file minikube -6- Check the service been created in minikube +1. Checks out the the source code +2. Installs & starts minikube +3. Tries out the cluster just by running `kubectl` command +4. Build the docker image using minikube's docker-env feature +5. Apply the yaml deployment yaml file minikube +6. Check the service been created in minikube -### example deployment yaml for minikube +### deployment.yaml used in the example ```yaml apiVersion: apps/v1 From babc4780c3dd13f6997138e4d6a1fb682f935996 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:26:55 -0700 Subject: [PATCH 08/16] improve link --- .../setup_minikube_in_github_actions.md | 82 +++++++++---------- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index a71668b2d67a..50cf6ebc3829 100644 --- a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -73,44 +73,44 @@ In this example, the above workflow yaml, will do the following steps on each co ### deployment.yaml used in the example -```yaml -apiVersion: apps/v1 -kind: Deployment -metadata: - name: example -spec: - selector: - matchLabels: - app: example - replicas: 2 - template: - metadata: - labels: - app: example - spec: - containers: - - name: example-api - imagePullPolicy: Never - image: local/example:latest - resources: - limits: - cpu: 50m - memory: 100Mi - requests: - cpu: 25m - memory: 10Mi - ports: - - containerPort: 8080 ---- -apiVersion: v1 -kind: Service -metadata: - name: example -spec: - type: NodePort - selector: - app: example - ports: - - port: 8080 - targetPort: 8080 -``` + ```yaml + apiVersion: apps/v1 + kind: Deployment + metadata: + name: example + spec: + selector: + matchLabels: + app: example + replicas: 2 + template: + metadata: + labels: + app: example + spec: + containers: + - name: example-api + imagePullPolicy: Never + image: local/example:latest + resources: + limits: + cpu: 50m + memory: 100Mi + requests: + cpu: 25m + memory: 10Mi + ports: + - containerPort: 8080 + --- + apiVersion: v1 + kind: Service + metadata: + name: example + spec: + type: NodePort + selector: + app: example + ports: + - port: 8080 + targetPort: 8080 + ``` From 818f7b5538aa3c3ca11c7f9a7132a5535d376cff Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:30:37 -0700 Subject: [PATCH 09/16] deployment yaml --- .../docs/tutorials/setup_minikube_in_github_actions.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index 50cf6ebc3829..3c76cae8c246 100644 --- a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -17,14 +17,15 @@ To install and start a minikube cluster, add the following step to your [github uses: medyagh/setup-minikube@master ``` -for more information checkout github actions marketplace :[setup-minikube](https://github.com/marketplace/actions/setup-minikube). +for more information see github actions marketplace [setup-minikube]( https://github.com/marketplace/actions/setup-minikube). ## Example: build image & deploy to minikube on each PR Requirements: - a valid Dockerfile -- a valid deployment.yaml to deploy image to kubernetes (make sure image pull policy is set to never see [bellow](/#deployment.yaml used in the example) for example) +- a valid [deployment.yaml](/#example deployment yaml) to deploy image to kubernetes +- in your deployment.yaml make sure the is set to `imagePullPolicy: Never` Steps: @@ -59,7 +60,7 @@ Steps: minikube service list minikube service example --url echo "------------------opening the service------------------" - curl $(minikube service example --url)/version + curl $(minikube service example --url) ``` In this example, the above workflow yaml, will do the following steps on each coming PR: @@ -71,7 +72,7 @@ In this example, the above workflow yaml, will do the following steps on each co 5. Apply the yaml deployment yaml file minikube 6. Check the service been created in minikube -### deployment.yaml used in the example +### example deployment yaml ```yaml apiVersion: apps/v1 From da17c513ec850ebd3626e3f557518327367aa482 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:32:00 -0700 Subject: [PATCH 10/16] pull policy --- .../en/docs/tutorials/setup_minikube_in_github_actions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index 3c76cae8c246..bf33138ff708 100644 --- a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -24,7 +24,7 @@ for more information see github actions marketplace [setup-minikube]( https://gi Requirements: - a valid Dockerfile -- a valid [deployment.yaml](/#example deployment yaml) to deploy image to kubernetes +- a valid [deployment.yaml](/#example-deployment-yaml) to deploy image to kubernetes - in your deployment.yaml make sure the is set to `imagePullPolicy: Never` Steps: From 12dd9097859e233f9a1dabd1182aa599a425f1f6 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:38:15 -0700 Subject: [PATCH 11/16] simpliofy --- .../tutorials/setup_minikube_in_github_actions.md | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index bf33138ff708..6b1051f79665 100644 --- a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -24,12 +24,11 @@ for more information see github actions marketplace [setup-minikube]( https://gi Requirements: - a valid Dockerfile -- a valid [deployment.yaml](/#example-deployment-yaml) to deploy image to kubernetes -- in your deployment.yaml make sure the is set to `imagePullPolicy: Never` +- a valid `deployment.yaml` file with `imagePullPolicy: Never` see bellow for an example -Steps: +Create workflow: -- Create a workflow yaml in your github repo in `.github/workflows/pr.yml` +- copy this yaml to your workflow file for example in `.github/workflows/pr.yml`: ```yaml name: CI @@ -63,7 +62,7 @@ Steps: curl $(minikube service example --url) ``` -In this example, the above workflow yaml, will do the following steps on each coming PR: +The above example workflow yaml, will do the following steps on each coming PR: 1. Checks out the the source code 2. Installs & starts minikube @@ -72,7 +71,7 @@ In this example, the above workflow yaml, will do the following steps on each co 5. Apply the yaml deployment yaml file minikube 6. Check the service been created in minikube -### example deployment yaml +### Example minikube deployment yaml with a service ```yaml apiVersion: apps/v1 From 28fb19b5262a94f60d8afb5625121beb0274af1c Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:45:12 -0700 Subject: [PATCH 12/16] address the review comments --- .../setup_minikube_in_github_actions.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index 6b1051f79665..ac9137a8121e 100644 --- a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -4,18 +4,18 @@ linkTitle: "minikube in github actions" weight: 1 date: 2020-06-02 description: > - How to use minikube in github actions for testing your app? + How to use minikube in github actions for testing your app --- To install and start a minikube cluster, add the following step to your [github action workflow](https://help.github.com/en/actions/configuring-and-managing-workflows/configuring-a-workflow). -```yaml - steps: - - name: start minikube - id: minikube - uses: medyagh/setup-minikube@master -``` + ```yaml + steps: + - name: start minikube + id: minikube + uses: medyagh/setup-minikube@master + ``` for more information see github actions marketplace [setup-minikube]( https://github.com/marketplace/actions/setup-minikube). @@ -24,7 +24,7 @@ for more information see github actions marketplace [setup-minikube]( https://gi Requirements: - a valid Dockerfile -- a valid `deployment.yaml` file with `imagePullPolicy: Never` see bellow for an example +- a valid `deployment.yaml` file with `imagePullPolicy: Never` see below for an example Create workflow: @@ -68,7 +68,7 @@ The above example workflow yaml, will do the following steps on each coming PR: 2. Installs & starts minikube 3. Tries out the cluster just by running `kubectl` command 4. Build the docker image using minikube's docker-env feature -5. Apply the yaml deployment yaml file minikube +5. Apply the deployment yaml file minikube 6. Check the service been created in minikube ### Example minikube deployment yaml with a service From 6de8748a17f560755e52f733257191cf1821c864 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:56:32 -0700 Subject: [PATCH 13/16] add link to docker-env too --- .../en/docs/tutorials/setup_minikube_in_github_actions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index ac9137a8121e..35297b505c7a 100644 --- a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -67,7 +67,7 @@ The above example workflow yaml, will do the following steps on each coming PR: 1. Checks out the the source code 2. Installs & starts minikube 3. Tries out the cluster just by running `kubectl` command -4. Build the docker image using minikube's docker-env feature +4. Build the docker image using minikube's [docker-env](({{< ref "/docs/commands/docker-env/" >}})) feature 5. Apply the deployment yaml file minikube 6. Check the service been created in minikube From b484c284216fce9ddd30a61ddf75e95593e101b6 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 14:59:59 -0700 Subject: [PATCH 14/16] docker-env link --- .../en/docs/tutorials/setup_minikube_in_github_actions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index 35297b505c7a..b7b5870cea95 100644 --- a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -67,7 +67,7 @@ The above example workflow yaml, will do the following steps on each coming PR: 1. Checks out the the source code 2. Installs & starts minikube 3. Tries out the cluster just by running `kubectl` command -4. Build the docker image using minikube's [docker-env](({{< ref "/docs/commands/docker-env/" >}})) feature +4. Build the docker image using minikube's [docker-env](({{< ref "/docs/commands/docker-env.md" >}})) feature 5. Apply the deployment yaml file minikube 6. Check the service been created in minikube From 91f9bcf93cf486c43f943c9f1b98177cf3079477 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 15:03:25 -0700 Subject: [PATCH 15/16] docker-env link --- .../en/docs/tutorials/setup_minikube_in_github_actions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index b7b5870cea95..54800f4a3677 100644 --- a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -67,7 +67,7 @@ The above example workflow yaml, will do the following steps on each coming PR: 1. Checks out the the source code 2. Installs & starts minikube 3. Tries out the cluster just by running `kubectl` command -4. Build the docker image using minikube's [docker-env](({{< ref "/docs/commands/docker-env.md" >}})) feature +4. Build the docker image using minikube's [docker-env]({{< ref "/docs/commands/docker-env.md" >}})feature 5. Apply the deployment yaml file minikube 6. Check the service been created in minikube From e15985f1573b5482dd1fd07fa8970a2e7580a436 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Tue, 2 Jun 2020 15:05:55 -0700 Subject: [PATCH 16/16] docker-env link --- .../en/docs/tutorials/setup_minikube_in_github_actions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md index 54800f4a3677..9b1fd6fbd412 100644 --- a/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md +++ b/site/content/en/docs/tutorials/setup_minikube_in_github_actions.md @@ -67,7 +67,7 @@ The above example workflow yaml, will do the following steps on each coming PR: 1. Checks out the the source code 2. Installs & starts minikube 3. Tries out the cluster just by running `kubectl` command -4. Build the docker image using minikube's [docker-env]({{< ref "/docs/commands/docker-env.md" >}})feature +4. Build the docker image using minikube's [docker-env]({{< ref "/docs/commands/docker-env.md" >}}) feature 5. Apply the deployment yaml file minikube 6. Check the service been created in minikube