From 9ff02aa8089cfa4499188f3c549421dc4b316898 Mon Sep 17 00:00:00 2001 From: Maximilian Hess Date: Tue, 14 May 2019 10:36:14 +0200 Subject: [PATCH 1/2] Return host IP when using vmware as vm driver. Adds the missing case "vmware" to return the host IP. --- pkg/minikube/cluster/cluster.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/minikube/cluster/cluster.go b/pkg/minikube/cluster/cluster.go index a8c799e5db39..e8703602fe32 100644 --- a/pkg/minikube/cluster/cluster.go +++ b/pkg/minikube/cluster/cluster.go @@ -380,6 +380,8 @@ func GetVMHostIP(host *host.Host) (net.IP, error) { return ip, nil case "xhyve", "hyperkit": return net.ParseIP("192.168.64.1"), nil + case "vmware": + return net.ParseIP("192.168.4.1"), nil default: return []byte{}, errors.New("Error, attempted to get host ip address for unsupported driver") } From a71143133dd83bf82489fadc094b2c8a0c899509 Mon Sep 17 00:00:00 2001 From: Maximilian Hess Date: Wed, 15 May 2019 11:39:06 +0200 Subject: [PATCH 2/2] Make derivation of Host IP address more generic when using vmware. --- pkg/minikube/cluster/cluster.go | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/pkg/minikube/cluster/cluster.go b/pkg/minikube/cluster/cluster.go index e8703602fe32..d25156a3e396 100644 --- a/pkg/minikube/cluster/cluster.go +++ b/pkg/minikube/cluster/cluster.go @@ -381,7 +381,15 @@ func GetVMHostIP(host *host.Host) (net.IP, error) { case "xhyve", "hyperkit": return net.ParseIP("192.168.64.1"), nil case "vmware": - return net.ParseIP("192.168.4.1"), nil + vmIPString, err := host.Driver.GetIP() + if err != nil { + return []byte{}, errors.Wrap(err, "Error getting VM IP address") + } + vmIP := net.ParseIP(vmIPString).To4() + if vmIP == nil { + return []byte{}, errors.Wrap(err, "Error converting VM IP address to IPv4 address") + } + return net.IPv4(vmIP[0], vmIP[1], vmIP[2], byte(1)), nil default: return []byte{}, errors.New("Error, attempted to get host ip address for unsupported driver") }