added missing err check to scanner and new section logs integration test

spowelljr · spowelljr · commit 66ecadce47fd · 2021-02-18T18:39:35.000-07:00
diff --git a/pkg/minikube/logs/logs.go b/pkg/minikube/logs/logs.go
@@ -214,6 +214,9 @@ func outputLastStart() error {
 	for s.Scan() {
 		out.Step(style.Empty, s.Text())
 	}
+	if err := s.Err(); err != nil {
+		return fmt.Errorf("failed to read file %s: %v", fp, err)
+	}
 	return nil
 }
 
diff --git a/test/integration/functional_test.go b/test/integration/functional_test.go
@@ -768,7 +768,7 @@ func validateLogsCmd(ctx context.Context, t *testing.T, profile string) {
 	if err != nil {
 		t.Errorf("%s failed: %v", rr.Command(), err)
 	}
-	expectedWords := []string{"apiserver", "Linux", "kubelet"}
+	expectedWords := []string{"apiserver", "Linux", "kubelet", "Last Start"}
 	switch ContainerRuntime() {
 	case "docker":
 		expectedWords = append(expectedWords, "Docker")

Original file line number	Diff line number	Diff line change
`@@ -214,6 +214,9 @@ func outputLastStart() error {`
`214`	`214`	`for s.Scan() {`
`215`	`215`	`out.Step(style.Empty, s.Text())`
`216`	`216`	`}`
	`217`	`+ if err := s.Err(); err != nil {`
	`218`	`+ return fmt.Errorf("failed to read file %s: %v", fp, err)`
	`219`	`+ }`
`217`	`220`	`return nil`
`218`	`221`	`}`
`219`	`222`
Original file line number	Diff line number	Diff line change
`@@ -768,7 +768,7 @@ func validateLogsCmd(ctx context.Context, t *testing.T, profile string) {`
`768`	`768`	`if err != nil {`
`769`	`769`	`t.Errorf("%s failed: %v", rr.Command(), err)`
`770`	`770`	`}`
`771`		`- expectedWords := []string{"apiserver", "Linux", "kubelet"}`
	`771`	`+ expectedWords := []string{"apiserver", "Linux", "kubelet", "Last Start"}`
`772`	`772`	`switch ContainerRuntime() {`
`773`	`773`	`case "docker":`
`774`	`774`	`expectedWords = append(expectedWords, "Docker")`