Skip to content

Commit 5741979

Browse files
committed
CI: Always require Docker to be running
1 parent 2ee03aa commit 5741979

File tree

2 files changed

+10
-22
lines changed

2 files changed

+10
-22
lines changed

hack/jenkins/common.ps1

+9-21
Original file line numberDiff line numberDiff line change
@@ -51,29 +51,17 @@ gsutil.cmd -m cp -r gs://minikube-builds/$env:MINIKUBE_LOCATION/testdata .
5151
gsutil.cmd -m cp -r gs://minikube-builds/$env:MINIKUBE_LOCATION/windows_integration_setup.ps1 out/
5252
gsutil.cmd -m cp -r gs://minikube-builds/$env:MINIKUBE_LOCATION/windows_integration_teardown.ps1 out/
5353

54-
# check for Docker CLI
55-
docker --help
56-
if ($lastexitcode -gt 0) {
57-
echo "Docker CLI not found, exiting."
58-
$json = "{`"state`": `"failure`", `"description`": `"Jenkins: Docker CLI not found`", `"target_url`": `"https://storage.googleapis.com/$gcs_bucket/$env:JOB_NAME.txt`", `"context`": `"$env:JOB_NAME`"}"
59-
Write-GithubStatus -JsonBody $json
54+
# Make sure Docker is up and running
55+
gsutil.cmd -m cp -r gs://minikube-builds/$env:MINIKUBE_LOCATION/setup_docker_desktop_windows.ps1 out/
56+
./out/setup_docker_desktop_windows.ps1
57+
If ($lastexitcode -gt 0) {
58+
echo "Docker failed to start, exiting."
59+
$json = "{`"state`": `"failure`", `"description`": `"Jenkins: docker failed to start`", `"target_url`": `"https://storage.googleapis.com/$gcs_bucket/$env:JOB_NAME.txt`", `"context`": `"$env:JOB_NAME`"}"
60+
Write-GithubStatus -JsonBody $json
6061
./out/windows_integration_teardown.ps1
61-
Exit $lastexitcode
62-
}
63-
64-
if ($driver -eq "docker") {
65-
# Make sure Docker is up and running
66-
gsutil.cmd -m cp -r gs://minikube-builds/$env:MINIKUBE_LOCATION/setup_docker_desktop_windows.ps1 out/
67-
./out/setup_docker_desktop_windows.ps1
68-
If ($lastexitcode -gt 0) {
69-
echo "Docker failed to start, exiting."
70-
$json = "{`"state`": `"failure`", `"description`": `"Jenkins: docker failed to start`", `"target_url`": `"https://storage.googleapis.com/$gcs_bucket/$env:JOB_NAME.txt`", `"context`": `"$env:JOB_NAME`"}"
71-
Write-GithubStatus -JsonBody $json
72-
./out/windows_integration_teardown.ps1
73-
Exit $lastexitcode
74-
}
75-
docker system prune -a --volumes -f
62+
Exit $lastexitcode
7663
}
64+
docker system prune -a --volumes -f
7765

7866
# install/update Go if required
7967
gsutil.cmd -m cp -r gs://minikube-builds/$env:MINIKUBE_LOCATION/installers/check_install_golang.ps1 out/

hack/jenkins/common.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ if [ "$(uname)" = "Darwin" ]; then
8181
export PATH=$PATH:/opt/homebrew/bin
8282
fi
8383

84-
if [ "$DRIVER" = "docker" ] && ! bash setup_docker_desktop_macos.sh; then
84+
if ! bash setup_docker_desktop_macos.sh; then
8585
retry_github_status "${COMMIT}" "${JOB_NAME}" "failure" "${access_token}" "${public_log_url}" "Jenkins: docker failed to start"
8686
exit 1
8787
fi

0 commit comments

Comments
 (0)