-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: fix-certs-generation-for-external-etcd #80867
kubeadm: fix-certs-generation-for-external-etcd #80867
Conversation
@fabriziopandini: GitHub didn't allow me to request PR reviews from the following users: seh. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
thanks @fabriziopandini
please add a release note.
/test pull-kubernetes-e2e-gce-device-plugin-gpu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fabriziopandini
/lgtm
/hold cancel |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes an error when using external etcd but storing some external etcd certificate in the
/etcd/kuberentes/pki
folder with the same name used by kubeadm for local etcd certificates.Which issue(s) this PR fixes:
Fixes # kubernetes/kubeadm#1276
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig cluster-lifecycle
/priority important-soon
/assign @neolit123 @rosti @yagonobre
/cc @seh