-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump NPD version to v0.7.1 for GCI #80726
Conversation
/sig node /hold |
@wangzhen127: GitHub didn't allow me to request PR reviews from the following users: xueweiz. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
By "to include metrics support for custom plugins", you meant #315 right? |
(sorry, just realized we are in different repo. |
Ah, my bad, that is included already. I think we can just use v0.7.0 in k8S 1.16. |
/test all |
7b8cef8
to
28eac12
Compare
/hold We should decide if we want NPD to look back from the beginning of the boot time. If yes, we need a new v0.7.1 release to include the fix. If not, we should remove the E2E test update. |
/hold cancel |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Random-Liu, wangzhen127, yguo0905 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR uses most recent NPD release (v0.7.1) for GCI.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: