Remove --interactive flag from kubectl logs #65420

jsoref · 2018-06-24T22:47:06Z

Remove deprecated --interactive flag from kubectl logs.

fixes kubernetes#61739

k8s-ci-robot · 2018-06-24T22:47:08Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jsoref · 2018-06-24T23:01:32Z

I've signed the cla. Is there some magic I need to perform to convince the bot that I've done so? -- Does my email address on the cla have to match the one github used for the commit?

idealhack · 2018-06-28T04:09:22Z

@jsoref Thanks for your work. AFAIK you are good to contribute now.

But I'm still not sure if we need this PR.

/sig cli

nikhita · 2018-06-28T04:30:46Z

/cc @juanvallejo

juanvallejo · 2018-06-28T14:26:59Z

pkg/kubectl/cmd/logs.go

@@ -126,7 +126,7 @@ func NewCmdLogs(f cmdutil.Factory, streams genericclioptions.IOStreams) *cobra.C
 	cmd.Flags().String("since-time", "", i18n.T("Only return logs after a specific date (RFC3339). Defaults to all logs. Only one of since-time / since may be used."))
 	cmd.Flags().Duration("since", 0, "Only return logs newer than a relative duration like 5s, 2m, or 3h. Defaults to all logs. Only one of since-time / since may be used.")
 	cmd.Flags().StringP("container", "c", "", "Print the logs of this container")
-	cmd.Flags().Bool("interactive", false, "If true, prompt the user for input when required.")
+	cmd.Flags().Bool("interactive", false, "[Ignored. It used to prompt the user for input when required.]")


This flag is marked deprecated, which means it will be removed within the next release or two.
I don't think it is necessary to point this out in the flag's description, as the deprecation message below already warns about this.

Effectively this was reported at 1.10.

The deprecation notice was added in f0aa606 circa Oct 2015. But, afaict, the feature was actually removed earlier than that.

The feature appears to have been added in eefaafc
Feb 2015.

I agree with @juanvallejo this was deprecated long enough. We can now safely remove the flag rather than updating the description like this.

idealhack · 2018-07-03T09:50:31Z

/ok-to-test

juanvallejo · 2018-07-03T18:18:48Z

/hold

I don't think updating the flag's description is something that is needed considering that the deprecation notice takes care of that.

I'd rather remove the flag altogether, especially given that it has been deprecated for multiple releases now.

cc @soltysh

soltysh · 2018-07-06T12:24:57Z

pkg/kubectl/cmd/logs.go

@@ -126,7 +126,7 @@ func NewCmdLogs(f cmdutil.Factory, streams genericclioptions.IOStreams) *cobra.C
 	cmd.Flags().String("since-time", "", i18n.T("Only return logs after a specific date (RFC3339). Defaults to all logs. Only one of since-time / since may be used."))
 	cmd.Flags().Duration("since", 0, "Only return logs newer than a relative duration like 5s, 2m, or 3h. Defaults to all logs. Only one of since-time / since may be used.")
 	cmd.Flags().StringP("container", "c", "", "Print the logs of this container")
-	cmd.Flags().Bool("interactive", false, "If true, prompt the user for input when required.")
+	cmd.Flags().Bool("interactive", false, "[Ignored. It used to prompt the user for input when required.]")


I agree with @juanvallejo this was deprecated long enough. We can now safely remove the flag rather than updating the description like this.

jsoref · 2018-08-08T03:23:26Z

/retest

juanvallejo · 2018-08-08T13:57:33Z

pkg/kubectl/cmd/logs.go

@@ -146,7 +146,6 @@ func NewCmdLogs(f cmdutil.Factory, streams genericclioptions.IOStreams) *cobra.C
 	cmd.Flags().DurationVar(&o.SinceSeconds, "since", o.SinceSeconds, "Only return logs newer than a relative duration like 5s, 2m, or 3h. Defaults to all logs. Only one of since-time / since may be used.")
 	cmd.Flags().StringVarP(&o.Container, "container", "c", o.Container, "Print the logs of this container")
 	cmd.Flags().BoolVar(&o.Interactive, "interactive", o.Interactive, "If true, prompt the user for input when required.")


You should delete the actual flag itself as well

Oops, I had removed it, but apparently failed to update my commit before pushing again...

juanvallejo · 2018-08-08T21:34:36Z

@jsoref Thanks.

/lgtm
/test pull-kubernetes-e2e-kops-aws

cc @soltysh for approval

mengqiy · 2018-08-09T15:43:13Z

/lgtm

@jsoref Can you please change the release note to

Drop --interactive flag from kubectl logs.

Or

Remove --interactive flag from kubectl logs.

k8s-ci-robot · 2018-08-09T15:43:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsoref, juanvallejo, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/kubectl/OWNERS~~ [mengqiy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mengqiy · 2018-08-10T15:50:27Z

@juanvallejo Can you /unhold this?

juanvallejo · 2018-08-10T15:53:02Z

/hold cancel

k8s-github-robot · 2018-08-10T17:14:52Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2018-08-10T18:30:32Z

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

Remove deprecated interactive flag

e272e27

fixes kubernetes#61739

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 24, 2018

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2018

k8s-ci-robot requested review from ericchiang and mengqiy June 24, 2018 22:47

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 24, 2018

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 24, 2018

k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Jun 28, 2018

k8s-ci-robot requested a review from juanvallejo June 28, 2018 04:30

juanvallejo reviewed Jun 28, 2018

View reviewed changes

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2018

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2018

soltysh requested changes Jul 6, 2018

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2018

jsoref force-pushed the issue-61739 branch from 737cc4b to c0f399d Compare August 7, 2018 19:48

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2018

jsoref mentioned this pull request Aug 8, 2018

e2e/unit/integration flake:pull-kubernetes-e2e-gce-100-performance #67112

Closed

juanvallejo reviewed Aug 8, 2018

View reviewed changes

jsoref force-pushed the issue-61739 branch from c0f399d to e272e27 Compare August 8, 2018 20:55

juanvallejo approved these changes Aug 8, 2018

View reviewed changes

k8s-ci-robot assigned juanvallejo Aug 8, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2018

k8s-ci-robot assigned mengqiy Aug 9, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2018

jsoref changed the title ~~Update help text to reflect reality~~ Remove --interactive flag from kubectl logs Aug 9, 2018

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2018

k8s-github-robot merged commit df43919 into kubernetes:master Aug 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove --interactive flag from kubectl logs #65420

Remove --interactive flag from kubectl logs #65420

jsoref commented Jun 24, 2018 •

edited

Loading

k8s-ci-robot commented Jun 24, 2018

jsoref commented Jun 24, 2018

idealhack commented Jun 28, 2018

nikhita commented Jun 28, 2018

juanvallejo Jun 28, 2018 •

edited

Loading

jsoref Jun 29, 2018

soltysh Jul 6, 2018

idealhack commented Jul 3, 2018

juanvallejo commented Jul 3, 2018

soltysh Jul 6, 2018

jsoref commented Aug 8, 2018

juanvallejo Aug 8, 2018

jsoref Aug 8, 2018

juanvallejo commented Aug 8, 2018

mengqiy commented Aug 9, 2018

k8s-ci-robot commented Aug 9, 2018

mengqiy commented Aug 10, 2018

juanvallejo commented Aug 10, 2018

k8s-github-robot commented Aug 10, 2018

k8s-github-robot commented Aug 10, 2018

Remove --interactive flag from kubectl logs #65420

Remove --interactive flag from kubectl logs #65420

Conversation

jsoref commented Jun 24, 2018 • edited Loading

k8s-ci-robot commented Jun 24, 2018

jsoref commented Jun 24, 2018

idealhack commented Jun 28, 2018

nikhita commented Jun 28, 2018

juanvallejo Jun 28, 2018 • edited Loading

Choose a reason for hiding this comment

jsoref Jun 29, 2018

Choose a reason for hiding this comment

soltysh Jul 6, 2018

Choose a reason for hiding this comment

idealhack commented Jul 3, 2018

juanvallejo commented Jul 3, 2018

soltysh Jul 6, 2018

Choose a reason for hiding this comment

jsoref commented Aug 8, 2018

juanvallejo Aug 8, 2018

Choose a reason for hiding this comment

jsoref Aug 8, 2018

Choose a reason for hiding this comment

juanvallejo commented Aug 8, 2018

mengqiy commented Aug 9, 2018

k8s-ci-robot commented Aug 9, 2018

mengqiy commented Aug 10, 2018

juanvallejo commented Aug 10, 2018

k8s-github-robot commented Aug 10, 2018

k8s-github-robot commented Aug 10, 2018

jsoref commented Jun 24, 2018 •

edited

Loading

juanvallejo Jun 28, 2018 •

edited

Loading