-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix instance metadata service URL. #49081
Conversation
var metadataURL = "http://169.254.169.254/metadata" | ||
const metaURL = "http://169.254.169.254/metadata/" | ||
|
||
var metadataURL = metaURL | ||
|
||
// SetMetadataURLForTesting is used to modify the URL used for | ||
// accessing the metadata server. Should only be used for testing! | ||
func SetMetadataURLForTesting(url string) { | ||
metadataURL = url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just for package local testing? Does it need to be public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
||
// SetMetadataURLForTesting is used to modify the URL used for | ||
// accessing the metadata server. Should only be used for testing! | ||
func SetMetadataURLForTesting(url string) { | ||
metadataURL = url | ||
} | ||
|
||
// ResetMetadataURLForTesting resets the metadata service URL to the default. | ||
func ResetMetadataURLForTesting() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment about unexporting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
/test pull-kubernetes-verify |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, colemickens, jackfrancis Associated issue requirement bypassed by: brendandburns The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test pull-kubernetes-e2e-gce-etcd3 |
2 similar comments
/test pull-kubernetes-e2e-gce-etcd3 |
/test pull-kubernetes-e2e-gce-etcd3 |
/retest |
Automatic merge from submit-queue (batch tested with PRs 49081, 49318, 49219, 48989, 48486) |
/sig azure |
Small fix @colemickens @jackfrancis