make using service account credentials from controllers optional

[deads2k]

Adds a flag to make the "SA per controller" behavior optional.

---

This change is

[k8s-ci-robot]

Jenkins verification failed for commit b4b66bfa8a1a5ddacdf03c535357a47f266f950f. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[liggitt]

LGTM, did you want to update any of the bring-up scripts to use this (e.g. local-up-cluster?)

[deads2k]

LGTM, did you want to update any of the bring-up scripts to use this (e.g. local-up-cluster?)

I don't think so. I'm hoping for a seamless transition at some point in 1.6

[k8s-ci-robot]

Jenkins GCE Node e2e failed for commit 5384822748de6b1d11831025472a7b8973fae09e. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[deads2k]

@k8s-bot node e2e test this: issue #35935

[k8s-ci-robot]

Jenkins unit/integration failed for commit e420d4b4c3fde135ae8777d9c69e2ef9c29f7ad9. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[k8s-ci-robot]

Jenkins GCI GKE smoke e2e failed for commit e420d4b4c3fde135ae8777d9c69e2ef9c29f7ad9. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[liggitt]

W1104 05:57:59.138] vendor/k8s.io/client-go/pkg/apis/componentconfig/types.generated.go:8963: x.UseServiceAccountCredentials undefined (type *KubeControllerManagerConfiguration has no field or method UseServiceAccountCredentials)
W1104 05:57:59.139] vendor/k8s.io/client-go/pkg/apis/componentconfig/types.generated.go:8973: x.UseServiceAccountCredentials undefined (type *KubeControllerManagerConfiguration has no field or method UseServiceAccountCredentials)
W1104 05:57:59.140] vendor/k8s.io/client-go/pkg/apis/componentconfig/types.generated.go:10223: x.UseServiceAccountCredentials undefined (type *KubeControllerManagerConfiguration has no field or method UseServiceAccountCredentials)
W1104 05:57:59.140] vendor/k8s.io/client-go/pkg/apis/componentconfig/types.generated.go:10225: x.UseServiceAccountCredentials undefined (type *KubeControllerManagerConfiguration has no field or method UseServiceAccountCredentials)
W1104 05:57:59.140] vendor/k8s.io/client-go/pkg/apis/componentconfig/types.generated.go:10781: x.UseServiceAccountCredentials undefined (type *KubeControllerManagerConfiguration has no field or method UseServiceAccountCredentials)
W1104 05:57:59.141] vendor/k8s.io/client-go/pkg/apis/componentconfig/types.generated.go:10783: x.UseServiceAccountCredentials undefined (type *KubeControllerManagerConfiguration has no field or method UseServiceAccountCredentials)

[liggitt]

@caesarxuchao does #35970 (comment) mean that things that change API types now need to happen in two pull requests, and wait in between for an updated client-go to be vendored in?

[deads2k]

@caesarxuchao does #35970 (comment) mean that things that change API types now need to happen in two pull requests, and wait in between for an updated client-go to be vendored in?

Might just have been a failure on my part to regen codecs. The object is internal only, so no codecs should be needed. I'll give it try.

[deads2k]

Might just have been a failure on my part to regen codecs. The object is internal only, so no codecs should be needed. I'll give it try.

Nope, that didn't do anything. @caesarxuchao are we just waiting for a sync to remove those files?

[caesarxuchao]

You can run hack/update-staging-client-go.sh to update the staging area, but that will pick up many other changes because the script hasn't been run for a week. You don't need to update the staging area if you don't need to update client-go right now. I'll enable the update/verify-staging-client-go.sh during the code freeze to keep the staging area up-to-date.

[k8s-github-robot]

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue