Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mock Driver to csi translation library to support unit testing #82670

Closed
davidz627 opened this issue Sep 12, 2019 · 2 comments · Fixed by #82683
Closed

Add Mock Driver to csi translation library to support unit testing #82670

davidz627 opened this issue Sep 12, 2019 · 2 comments · Fixed by #82683
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@davidz627
Copy link
Contributor

Right now only real drivers are supported in the translation library, this makes unit testing especially difficult. If we add a mock driver we should be able to unit test external provisioner (and maybe other components) better
@davidz627 davidz627 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 12, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 12, 2019
@davidz627 davidz627 mentioned this issue Sep 12, 2019
Merged
@davidz627
Copy link
Contributor Author

/sig storage
/cc @ddebroy @leakingtapan @shanesiebken

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 12, 2019
@davidz627
Copy link
Contributor Author

Nevermind, there's no mock in-tree plugin so theres no natural translation to/from the mock driver. I may just have to turn the translation library into a fakeable interface.

@davidz627 davidz627 mentioned this issue Sep 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Milestone
No milestone
2 participants
@davidz627 @k8s-ci-robot