-
Notifications
You must be signed in to change notification settings - Fork 196
Conversation
LGTM, needs a rebase... |
Should it use something like I was thinking about evaluating |
bd44c3f
to
d093ef8
Compare
@colemickens that's a good question indeed. Terraform does a good job at figuring out when resources need to be updated vs re-created entierely, but there is probably something we should do outside of Terraform, especially to cater for non-Terraform implementations of phase 1. I think instance prefix, or cluster name would be good candidates for that. I also think that generated code in the sense we have it right now should be eligible to a life of it's own, i.e. users might need to modify and redistribute the generated code. |
@@ -45,6 +45,14 @@ menuconfig: .tmp/mconf | |||
echo-config: .config.json | |||
cat $< | |||
|
|||
deploy: .config.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose you can do:
deploy destroy: .config.json
$(MAKE) do WHAT=$@
Isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@colemickens compromise: name the tf files differently based on instance prefix which is basically cluster name. I pushed a change to all.jsonnet that does that. I'm happy to not use .tmp but I don't know what the structure should look like yet. |
That doesn't include the crypto assets then. I think it would be good for there to be an |
Ouch, the crypto stuff is definitely not threadsafe right now... Ok I'm going to work on #145 next. |
I'm going to leave that work for a follow up. |
No description provided.