Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Welcome @plusiv!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @plusiv. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: plusiv
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Hi people @ardaguclu @brianpursley !

What do you think about this PR?

I'd like to see this issue be triaged first, to agree on an implementation. Currently, people can use the --from-file flag to read a multi-line secret and I wonder if that is good enough to satisfy the use case.

But regarding this specific PR...

I don't think it would always preserve the existing behavior. For example, these edge cases I think would be a problem:

MY_PASSWORD="*2KHjkdf!@kdlq

or

MY_PASSWORD="*2KHjkdf!@kdlq
SOME_OTHER_VALUE=hjef@!kjdfo"

If this issue does get triaged accepted, I think that something like this might be a more robust (and easier to implement) way of doing it:

MY_MULTILINE_VALUE="""
Line 1
Line 2
"""

That way, the only potential breaking change would be if someone really did have a secret that was exactly three double quotes """ which is very unlikely.

Before doing any more work on it though, it is probably best to bring this issue up in the next monthly SIG-CLI "bug scrub" meeting where we usually discuss new, un-triaged issues, or as a topic at the next regular bi-weekly SIG-CLI meeting.

Thanks for your feedback @brianpursley .

Regarding to this:

I'd like to see this issue be triaged first, to agree on an implementation. Currently, people can use the --from-file flag to read a multi-line secret and I wonder if that is good enough to satisfy the use case.

I believe it's very common for developers to store all their secrets in a single file (usually a .env file). So, it would be better to avoid using multiple files if possible.