Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom resource definition #457

Closed
andyxning opened this issue May 17, 2018 · 7 comments
Closed

Add support for custom resource definition #457

andyxning opened this issue May 17, 2018 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@andyxning
Copy link
Member

andyxning commented May 17, 2018

Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature

What happened:
As with the popular about operators, CRDs are used more and more frequently in Kubernetes. We should try to add support for collecting metrics about CRDs.

But, as CRDs are defined by different users and may vary from user to user, we may need to extract some common metrics or fields.

Maybe we should work with people from https://github.com/operator-framework as it may become the de facto sdks to develop operators.

I am not quite sure what to do for now, just propose this issue and hope to learn some suggestions from others.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 17, 2018
@brancz
Copy link
Member

brancz commented May 17, 2018

My take: operators should expose metrics about the objects they expose themselves. There is no meaningful extension kube-state-metrics can do other than potentially providing a library to reuse the mechanisms built in this repository.

The Prometheus Operator does this today already.

@andyxning
Copy link
Member Author

Background:

I am currently working on nsq operator, so i think some similar metrics about crds should also be exposed.

@brancz That is a good suggestion. Only the custom controller manager, i.e., operator can best know and learn how to expose important object metrics.

@brancz
Copy link
Member

brancz commented May 18, 2018

Only the custom controller manager, i.e., operator can best know and learn how to expose important object metrics.

Precisely.

@brancz
Copy link
Member

brancz commented May 18, 2018

Do open an issue on the operator framework as I feel it should give you a nice surface to expose metrics.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2018
@brancz
Copy link
Member

brancz commented Aug 16, 2018

I think we can close this.

@anandsinghkunwar
Copy link

Don't metrics like *_created make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants