Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor typos in Makefile #971

Closed
jaden-young opened this issue Mar 28, 2018 · 1 comment
Closed

Minor typos in Makefile #971

jaden-young opened this issue Mar 28, 2018 · 1 comment

Comments

@jaden-young
Copy link
Contributor

jaden-young commented Mar 28, 2018 •
edited
Loading

kompose/Makefile

Lines 70 to 71 in 39ad614

.PHONY: generate-test-cmd
gen-cmd:

Should probably be

.PHONY gen-cmd
gen-cmd:

and

kompose/Makefile

Line 129 in 39ad614

.PHONE: test-k8s

Should probably be

.PHONY test-k8s
@hangyan
Copy link
Contributor

hangyan commented Mar 29, 2018

@jaden-young Thanks for point out this ! Would you mind to create a PR to fix this?

@jaden-young jaden-young mentioned this issue Mar 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hangyan @jaden-young