adding timestamp in k8s artifacts

[surajnarwade]

I was validating results from kompose using kubeval, I got following output:

$ kubeval frontend-deployment.yaml 
The document frontend-deployment.yaml contains an invalid Deployment
--> spec.template.metadata.creationTimestamp: Invalid type. Expected: string, given: null
--> metadata.creationTimestamp: Invalid type. Expected: string, given: null

Should we add timestamp in spec ?
any thoughts, @kadel @surajssd @cdrage

[kadel]

I don't think it should be set, and null should be valid for createationTimestamp

It looks like bug in kubeval

If you look at the reference documentatoin it says
"CreationTimestamp is a timestamp representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations. Clients may not set this value. It is represented in RFC3339 form and is in UTC. Populated by the system. "

[surajnarwade]

@kadel , gotcha, thanks for clarifying

[surajssd]

@surajnarwade do you mind reporting it in kubeval ?

[garethr]

Hey, author of kubeval here.

According to the Kubernetes spec (https://github.com/garethr/kubernetes-json-schema/blob/master/master-standalone/deployment.json#L3511-L3514) the error is correct. Unfortunately Kubernetes doesn't exactly use this spec internally, so kubeval is finding upstream bugs in how the types are output to JSON Schema in the OpenAPI spec in a few places.

I've opened instrumenta/kubeval#16 to track.

@surajnarwade note that kubeval will shortly be available as a Go library as well, so it might be interesting to build the validation in as an optional step into Kompose?

[surajnarwade]

@garethr that will be awesome

[surajssd]

@garethr thanks, having a golang binary will help both kompose and kedge !

cc: @containscafeine @kadel

[garethr]

Usage as a go library is now in master with a little documentation. https://github.com/garethr/kubeval#library

I'd love any feedback on that interface, or other things folks would like to see.

[garethr]

@surajnarwade just to let you know I've updated the schemas and the service definition should now work as expected. All the details in instrumenta/kubeval#16 for anyone following along.

[surajnarwade]

@garethr awesome, It's working as expected, Thanks :)