Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we support converting to Replica Sets? #63

Closed
janetkuo opened this issue Jul 25, 2016 · 4 comments
Closed

Should we support converting to Replica Sets? #63

janetkuo opened this issue Jul 25, 2016 · 4 comments
Assignees

Comments

@janetkuo
Copy link
Member

Since we discourage people from using Replica Sets directly (instead they should use Deployments), how about removing the support for converting to RS? On the other hand, converting to Replication Controllers makes sense for people haven't adopted Deployments.

@kadel
Copy link
Member

kadel commented Jul 26, 2016

I was also thinking about this and I agree completely, we should discourage people from using Replica Sets directly.

@surajssd
Copy link
Member

Or can we have it on k8s's version ? Like for k8s 1.2 we support Deployments by default and for before we use replication controllers. Or introduce some kinda flag?

@pradeepto
Copy link

@surajssd That will add unnecessary complications to the code base. Since kompose is new upcoming tool, I wonder if it makes sense to support features that are being actively discouraged/deprecated.

👍 @janetkuo with this suggestion.

@janetkuo janetkuo self-assigned this Jul 26, 2016
@ngtuna
Copy link
Contributor

ngtuna commented Jul 27, 2016

+1 @janetkuo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants