Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test should show diff #604

Closed
kadel opened this issue May 16, 2017 · 3 comments
Closed

Failing test should show diff #604

kadel opened this issue May 16, 2017 · 3 comments
Assignees
@surajnarwade
Labels
kind/testing priority/P3

Comments

@kadel
Copy link
Member

kadel commented May 16, 2017

If one test in make test-cmd fails it just shows following message:

FAIL: converted output does not match

It is quite annoying to debug why this test is failing because you have to run it again manually to catch output and do diff with the expected output.

Diff should be shown automatically for.
@cdrage
Copy link
Member

cdrage commented May 17, 2017

I totally agree. It's annoying to not know what's exactly wrong between the two 👎

@surajnarwade
Copy link
Contributor

taking this up :)

@kadel kadel mentioned this issue Jun 7, 2017
Merged
@surajnarwade surajnarwade mentioned this issue Jun 13, 2017
Merged
@surajnarwade
Copy link
Contributor

@cdrage @kadel we can close this as #638 is merged now

@cdrage cdrage closed this as completed Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@surajnarwade surajnarwade

Labels
kind/testing priority/P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kadel @cdrage @surajnarwade