Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no commit hash in kompose 0.3.0 version information #487

Closed
dustymabe opened this issue Mar 13, 2017 · 6 comments
Closed

no commit hash in kompose 0.3.0 version information #487

dustymabe opened this issue Mar 13, 2017 · 6 comments

Comments

@dustymabe
Copy link
Contributor

link-to-rpm

For last release I saw:

$ kompose --version
kompose version 0.1.2 (92ea047)

With newer rpm I see:

[vagrant@f25vanilla ~]$ kompose version
0.3.0 (HEAD)

also the move from kompose --version to kompose version is odd. We should probably support --version as well, if possible.

[vagrant@f25vanilla ~]$ kompose --version
Error: unknown flag: --version
...
@cdrage
Copy link
Member

cdrage commented Mar 13, 2017

@dustymabe

We moved to kompose version instead of kompose --version in order to familiarize those who have used kubectl or oc. Since development usually overlaps between all three, we found that having similar commands help!

Yup, the has was my fault. I added that manually last version when it should of been just (HEAD). See #422

@cdrage
Copy link
Member

cdrage commented Mar 13, 2017

We need to have a discussion about including git hash in the version as per #422 ... I like having a commit ID within it, but the problem is when people go get it, it'll appear as the git commit hard-coded in when in reality it's the latest dev branch.

@dustymabe
Copy link
Contributor Author

hmm. what I'm saying is that I prefer the more verbose output. I wish it was:

[vagrant@f25vanilla ~]$ kompose version
0.3.0 (aaabbbc)

@dustymabe
Copy link
Contributor Author

if this can't be achieved, that is ok

@kadel
Copy link
Member

kadel commented Mar 15, 2017

It can be achieved, but it has to be build from source cloned from git with proper ldflags or using make build

@surajssd
Copy link
Member

I think this is solved so closing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants